Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1600337
| From | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412 |
| Date | 2017-03-14 14:20 +0100 |
| Message-ID | <tkUwO-Bf-31@gated-at.bofh.it> (permalink) |
| References | <tjT05-5YC-3@gated-at.bofh.it> <tkUn8-x2-29@gated-at.bofh.it> <tjT06-5YC-5@gated-at.bofh.it> <tkUn8-x2-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Mar 14, 2017 at 3:03 PM, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote: > > Hi, > > On Saturday, March 11, 2017 07:25:22 PM Krzysztof Kozlowski wrote: >> The Exynos4412 has the same watchdog as newer SoCs (e.g. Exynos5250). >> Just like the others, for working it requires additional steps in Power >> Management Unit: unmasking the reset request and enabling the system >> reset. Without these additional steps in PMU, the watchdog will not be >> able to reset the system on expiration event. >> >> Change the compatible of Exynos4412 watchdog device node to >> samsung,exynos5250-wdt which includes the additional PMU steps. > > This is going to confuse people. How's about doing it cleanly > (by adding samsung,exynos4412-wdt compatible and convert existing > users to use instead)? I don't find usage of 5250 in Exynos4412 DTS as confusing because since long time I do not threat these numbers as having any meaning (e.g. 3250 is newer...). Yes, we can duplicate the compatible for that purpose. Care to send a patch for this? Best regards, Krzysztof
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412 Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-11 18:30 +0100
Re: [PATCH v2 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412 Guenter Roeck <linux@roeck-us.net> - 2017-03-12 21:50 +0100
Re: [PATCH v2 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412 Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-13 07:50 +0100
Re: [PATCH v2 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-14 14:10 +0100
Re: [PATCH v2 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412 Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-14 14:20 +0100
Re: [PATCH v2 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-14 15:10 +0100
csiph-web