Re: [PATCH] ks7010: adding parenthesis to macro argument

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ks7010: adding parenthesis to macro argument
Date	2017-03-14 11:50 +0100
Message-ID	<tkSbD-7fP-1@gated-at.bofh.it> (permalink)
References	<tkNvk-3Vo-11@gated-at.bofh.it> <tkRfA-6BP-5@gated-at.bofh.it> <tkRyV-6XA-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Mar 14, 2017 at 03:01:50AM -0700, Pushkar Jambhlekar wrote:
> Hi Dan,
> 
> I am trying to fix warnings by "checkpatch.pl". Even though it is not
> super exciting, no harm to follow correct way.
> 

The harm is that it takes something that's already terrible and makes it
even more unreadable.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ks7010: adding parenthesis to macro argument Pushkar Jambhlekar <pushkar.iit@gmail.com> - 2017-03-14 06:50 +0100
  Re: [PATCH] ks7010: adding parenthesis to macro argument Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-14 10:50 +0100
    Re: [PATCH] ks7010: adding parenthesis to macro argument Pushkar Jambhlekar <pushkar.iit@gmail.com> - 2017-03-14 11:10 +0100
      Re: [PATCH] ks7010: adding parenthesis to macro argument Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-14 11:50 +0100

csiph-web