Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1600043
| From | Pushkar Jambhlekar <pushkar.iit@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] ks7010: adding parenthesis to macro argument |
| Date | 2017-03-14 06:50 +0100 |
| Message-ID | <tkNvk-3Vo-11@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
Description: In driver module ks7010, "checkpatch.pl" flags error for adding parenthesis around macro params. Also, removing extra line. Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com> --- drivers/staging/ks7010/ks7010_sdio.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c index a604c83..644b8d4 100644 --- a/drivers/staging/ks7010/ks7010_sdio.c +++ b/drivers/staging/ks7010/ks7010_sdio.c @@ -35,18 +35,18 @@ MODULE_DEVICE_TABLE(sdio, ks7010_sdio_ids); /* macro */ #define inc_txqhead(priv) \ - (priv->tx_dev.qhead = (priv->tx_dev.qhead + 1) % TX_DEVICE_BUFF_SIZE) + ((priv)->tx_dev.qhead = ((priv)->tx_dev.qhead + 1) % TX_DEVICE_BUFF_SIZE) #define inc_txqtail(priv) \ - (priv->tx_dev.qtail = (priv->tx_dev.qtail + 1) % TX_DEVICE_BUFF_SIZE) + ((priv)->tx_dev.qtail = ((priv)->tx_dev.qtail + 1) % TX_DEVICE_BUFF_SIZE) #define cnt_txqbody(priv) \ - (((priv->tx_dev.qtail + TX_DEVICE_BUFF_SIZE) - (priv->tx_dev.qhead)) % TX_DEVICE_BUFF_SIZE) + ((((priv)->tx_dev.qtail + TX_DEVICE_BUFF_SIZE) - ((priv)->tx_dev.qhead)) % TX_DEVICE_BUFF_SIZE) #define inc_rxqhead(priv) \ - (priv->rx_dev.qhead = (priv->rx_dev.qhead + 1) % RX_DEVICE_BUFF_SIZE) + ((priv)->rx_dev.qhead = ((priv)->rx_dev.qhead + 1) % RX_DEVICE_BUFF_SIZE) #define inc_rxqtail(priv) \ - (priv->rx_dev.qtail = (priv->rx_dev.qtail + 1) % RX_DEVICE_BUFF_SIZE) + ((priv)->rx_dev.qtail = ((priv)->rx_dev.qtail + 1) % RX_DEVICE_BUFF_SIZE) #define cnt_rxqbody(priv) \ - (((priv->rx_dev.qtail + RX_DEVICE_BUFF_SIZE) - (priv->rx_dev.qhead)) % RX_DEVICE_BUFF_SIZE) + ((((priv)->rx_dev.qtail + RX_DEVICE_BUFF_SIZE) - ((priv)->rx_dev.qhead)) % RX_DEVICE_BUFF_SIZE) static int ks7010_sdio_read(struct ks_wlan_private *priv, unsigned int address, unsigned char *buffer, int length) @@ -884,7 +884,6 @@ static void ks7010_card_init(struct ks_wlan_private *priv) if (priv->mac_address_valid && priv->version_size) priv->dev_state = DEVICE_STATE_PREINIT; - hostif_sme_enqueue(priv, SME_GET_EEPROM_CKSUM); /* load initial wireless parameter */ -- 2.7.4
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] ks7010: adding parenthesis to macro argument Pushkar Jambhlekar <pushkar.iit@gmail.com> - 2017-03-14 06:50 +0100
Re: [PATCH] ks7010: adding parenthesis to macro argument Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-14 10:50 +0100
Re: [PATCH] ks7010: adding parenthesis to macro argument Pushkar Jambhlekar <pushkar.iit@gmail.com> - 2017-03-14 11:10 +0100
Re: [PATCH] ks7010: adding parenthesis to macro argument Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-14 11:50 +0100
csiph-web