Re: [PATCH] staging: atomisp: use k{v}zalloc instead of k{v}alloc and memset

From	DaeSeok Youn <daeseok.youn@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: atomisp: use k{v}zalloc instead of k{v}alloc and memset
Date	2017-03-14 02:20 +0100
Message-ID	<tkJi2-12I-9@gated-at.bofh.it> (permalink)
References	<tkvRL-7Mz-1@gated-at.bofh.it> <tkCqe-422-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2017-03-14 2:54 GMT+09:00 Alan Cox <alan@linux.intel.com>:
>
> On Mon, 2017-03-13 at 19:54 +0900, Daeseok Youn wrote:
> > If the atomisp_kernel_zalloc() has "true" as a second parameter, it
> > tries to allocate zeroing memory from kmalloc(vmalloc) and memset.
> > But using kzalloc is rather than kmalloc followed by memset with 0.
> > (vzalloc is for same reason with kzalloc)
>
> This is true but please don't apply this. There are about five other
> layers of indirection for memory allocators that want removing first so
> that the driver just uses the correct kmalloc/kzalloc/kv* functions in
> the right places.
right. kvmalloc/kvzalloc would be used after preparing those
interfaces in staging tree.
I will try to change all the atomisp_kernel_m{z}alloc() callers to
correct functions to allocate memory.

Thanks.
Regards,
Jake.

>
> Alan
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: atomisp: use k{v}zalloc instead of k{v}alloc and  memset Daeseok Youn <daeseok.youn@gmail.com> - 2017-03-13 12:00 +0100
  Re: [PATCH] staging: atomisp: use k{v}zalloc instead of k{v}alloc  and memset Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-13 13:00 +0100
    Re: [PATCH] staging: atomisp: use k{v}zalloc instead of k{v}alloc and memset DaeSeok Youn <daeseok.youn@gmail.com> - 2017-03-13 15:10 +0100
      Re: [PATCH] staging: atomisp: use k{v}zalloc instead of k{v}alloc and memset DaeSeok Youn <daeseok.youn@gmail.com> - 2017-03-13 16:50 +0100
  Re: [PATCH] staging: atomisp: use k{v}zalloc instead of k{v}alloc  and memset Alan Cox <alan@linux.intel.com> - 2017-03-13 19:00 +0100
    Re: [PATCH] staging: atomisp: use k{v}zalloc instead of k{v}alloc and memset DaeSeok Youn <daeseok.youn@gmail.com> - 2017-03-14 02:20 +0100

csiph-web