Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1599661

Re: [PATCH] staging: atomisp: use k{v}zalloc instead of k{v}alloc and memset

Show all headers | View raw

On Mon, 2017-03-13 at 19:54 +0900, Daeseok Youn wrote:
> If the atomisp_kernel_zalloc() has "true" as a second parameter, it
> tries to allocate zeroing memory from kmalloc(vmalloc) and memset.
> But using kzalloc is rather than kmalloc followed by memset with 0.
> (vzalloc is for same reason with kzalloc)

This is true but please don't apply this. There are about five other
layers of indirection for memory allocators that want removing first so
that the driver just uses the correct kmalloc/kzalloc/kv* functions in
the right places.

Alan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: atomisp: use k{v}zalloc instead of k{v}alloc and  memset Daeseok Youn <daeseok.youn@gmail.com> - 2017-03-13 12:00 +0100
  Re: [PATCH] staging: atomisp: use k{v}zalloc instead of k{v}alloc  and memset Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-13 13:00 +0100
    Re: [PATCH] staging: atomisp: use k{v}zalloc instead of k{v}alloc and memset DaeSeok Youn <daeseok.youn@gmail.com> - 2017-03-13 15:10 +0100
      Re: [PATCH] staging: atomisp: use k{v}zalloc instead of k{v}alloc and memset DaeSeok Youn <daeseok.youn@gmail.com> - 2017-03-13 16:50 +0100
  Re: [PATCH] staging: atomisp: use k{v}zalloc instead of k{v}alloc  and memset Alan Cox <alan@linux.intel.com> - 2017-03-13 19:00 +0100
    Re: [PATCH] staging: atomisp: use k{v}zalloc instead of k{v}alloc and memset DaeSeok Youn <daeseok.youn@gmail.com> - 2017-03-14 02:20 +0100

csiph-web