Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1599692

[PATCH v1] hpet: Make cmd parameter of hpet_ioctl_common() unsigned

Show all headers | View raw

The value passed by the two callers of the function is unsigned anyway.

Making the parameter unsigned fixes the following warning when building
with clang:

drivers/char/hpet.c:588:7: error: overflow converting case value to switch condition type (2149083139 to 18446744071563667459) [-Werror,-Wswitch]
        case HPET_INFO:
             ^
include/uapi/linux/hpet.h:18:19: note: expanded from macro 'HPET_INFO'
                        ^
include/uapi/asm-generic/ioctl.h:77:28: note: expanded from macro '_IOR'
                                ^
include/uapi/asm-generic/ioctl.h:66:2: note: expanded from macro '_IOC'
        (((dir)  << _IOC_DIRSHIFT) | \

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
 drivers/char/hpet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
index 20b32bb8c2af..0d633b76c29e 100644
--- a/drivers/char/hpet.c
+++ b/drivers/char/hpet.c
@@ -574,7 +574,7 @@ static inline unsigned long hpet_time_div(struct hpets *hpets,
 }
 
 static int
-hpet_ioctl_common(struct hpet_dev *devp, int cmd, unsigned long arg,
+hpet_ioctl_common(struct hpet_dev *devp, unsigned int cmd, unsigned long arg,
 		  struct hpet_info *info)
 {
 	struct hpet_timer __iomem *timer;
-- 
2.12.0.246.ga2ecc84866-goog

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v1] hpet: Make cmd parameter of hpet_ioctl_common() unsigned Matthias Kaehlcke <mka@chromium.org> - 2017-03-13 20:00 +0100
  Re: [PATCH v1] hpet: Make cmd parameter of hpet_ioctl_common()  unsigned Clemens Ladisch <clemens@ladisch.de> - 2017-03-14 09:10 +0100
    Re: [PATCH v1] hpet: Make cmd parameter of hpet_ioctl_common() unsigned Grant Grundler <grundler@chromium.org> - 2017-03-23 22:50 +0100
      Re: [PATCH v1] hpet: Make cmd parameter of hpet_ioctl_common()  unsigned Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-24 08:00 +0100
        Re: [PATCH v1] hpet: Make cmd parameter of hpet_ioctl_common() unsigned Grant Grundler <grundler@chromium.org> - 2017-03-24 19:20 +0100

csiph-web