Re: [PATCH v1] hpet: Make cmd parameter of hpet_ioctl_common() unsigned

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1] hpet: Make cmd parameter of hpet_ioctl_common() unsigned
Date	2017-03-24 08:00 +0100
Message-ID	<tormx-64z-1@gated-at.bofh.it> (permalink)
References	<tkDmi-4GD-11@gated-at.bofh.it> <tkPGO-5DN-9@gated-at.bofh.it> <toiMi-8kl-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 23, 2017 at 02:47:39PM -0700, Grant Grundler wrote:
> On Tue, Mar 14, 2017 at 12:56 AM, Clemens Ladisch <clemens@ladisch.de> wrote:
> > Matthias Kaehlcke wrote:
> >> The value passed by the two callers of the function is unsigned anyway.
> >
> > Indeed; and those are just simple wrappers.
> >
> >> Making the parameter unsigned fixes the following warning when building
> >> with clang:
> >>
> >> drivers/char/hpet.c:588:7: error: overflow converting case value to switch condition type (2149083139 to 18446744071563667459) [-Werror,-Wswitch]
> >>         case HPET_INFO:
> >>              ^
> >> include/uapi/linux/hpet.h:18:19: note: expanded from macro 'HPET_INFO'
> >>                         ^
> >> include/uapi/asm-generic/ioctl.h:77:28: note: expanded from macro '_IOR'
> >>                                 ^
> >> include/uapi/asm-generic/ioctl.h:66:2: note: expanded from macro '_IOC'
> >>         (((dir)  << _IOC_DIRSHIFT) | \
> >>
> >> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> >
> > Acked-by: Clemens Ladisch <clemens@ladisch.de>
> 
> Any other feedback on this patch?
> Or has this already been added to someone's "for-linus" branch?
> 
> just looking for update on patch status.

This is already in my -next branch, to go into 4.12-rc1.  Should it get
into 4.11-final instead?

thanks,

greg k-h

Thread

Re: [PATCH v1] hpet: Make cmd parameter of hpet_ioctl_common()  unsigned Clemens Ladisch <clemens@ladisch.de> - 2017-03-14 09:10 +0100
  Re: [PATCH v1] hpet: Make cmd parameter of hpet_ioctl_common() unsigned Grant Grundler <grundler@chromium.org> - 2017-03-23 22:50 +0100
    Re: [PATCH v1] hpet: Make cmd parameter of hpet_ioctl_common()  unsigned Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-24 08:00 +0100
      Re: [PATCH v1] hpet: Make cmd parameter of hpet_ioctl_common() unsigned Grant Grundler <grundler@chromium.org> - 2017-03-24 19:20 +0100

csiph-web