[PATCH v2 3/9] net: stmmac: Disable PTP reference clock on error

From	Thierry Reding <thierry.reding@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH v2 3/9] net: stmmac: Disable PTP reference clock on error
Date	2017-03-10 17:40 +0100
Message-ID	<tjvKa-6B0-5@gated-at.bofh.it> (permalink)
References	<tjvKa-6B0-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Thierry Reding <treding@nvidia.com>

If an error occurs while opening the device, make sure to disable the
PTP reference clock.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 7c38c9baf238..6060410d2b9e 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -1754,6 +1754,13 @@ static int stmmac_hw_setup(struct net_device *dev, bool init_ptp)
 	return 0;
 }
 
+static void stmmac_hw_teardown(struct net_device *dev)
+{
+	struct stmmac_priv *priv = netdev_priv(dev);
+
+	clk_disable_unprepare(priv->plat->clk_ptp_ref);
+}
+
 /**
  *  stmmac_open - open entry point of the driver
  *  @dev : pointer to the device structure.
@@ -1863,6 +1870,7 @@ static int stmmac_open(struct net_device *dev)
 		phy_stop(dev->phydev);
 
 	del_timer_sync(&priv->txtimer);
+	stmmac_hw_teardown(dev);
 init_error:
 	free_dma_desc_resources(priv);
 dma_desc_error:
-- 
2.12.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v2 3/9] net: stmmac: Disable PTP reference clock on error Thierry Reding <thierry.reding@gmail.com> - 2017-03-10 17:40 +0100

csiph-web