[PATCH v2 5/9] net: stmmac: Check for DMA mapping errors

From	Thierry Reding <thierry.reding@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH v2 5/9] net: stmmac: Check for DMA mapping errors
Date	2017-03-10 17:40 +0100
Message-ID	<tjvKa-6B0-1@gated-at.bofh.it> (permalink)
References	<tjvKa-6B0-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Thierry Reding <treding@nvidia.com>

When DMA mapping an SKB fragment, the mapping must be checked for
errors, otherwise the DMA debug code will complain upon unmap.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index ce6d7e791f3f..eba9088e1f61 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -2079,6 +2079,8 @@ static netdev_tx_t stmmac_tso_xmit(struct sk_buff *skb, struct net_device *dev)
 		des = skb_frag_dma_map(priv->device, frag, 0,
 				       skb_frag_size(frag),
 				       DMA_TO_DEVICE);
+		if (dma_mapping_error(priv->device, des))
+			goto dma_map_err;
 
 		stmmac_tso_allocator(priv, des, skb_frag_size(frag),
 				     (i == nfrags - 1));
-- 
2.12.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v2 5/9] net: stmmac: Check for DMA mapping errors Thierry Reding <thierry.reding@gmail.com> - 2017-03-10 17:40 +0100

csiph-web