Re: kexec, x86/purgatory: Cleanup the unholy mess

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: kexec, x86/purgatory: Cleanup the unholy mess
Date	2017-03-10 16:00 +0100
Message-ID	<tjubn-5v7-9@gated-at.bofh.it> (permalink)
References	<tjrGA-3S0-97@gated-at.bofh.it> <tjt5F-4JP-49@gated-at.bofh.it> <tjtfl-4NB-49@gated-at.bofh.it> <tjtS4-5k0-69@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 10 Mar 2017, Mike Galbraith wrote:
> Stuffing the lot into .kexec-purgatory worked.

You beat me to it :)

And that's how that whole thing should have been done in the very beginning
instead of relying on uncomprehensible compile/link magics.

Thanks,

	tglx

> ---
>  arch/x86/purgatory/purgatory.c |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> --- a/arch/x86/purgatory/purgatory.c
> +++ b/arch/x86/purgatory/purgatory.c
> @@ -16,13 +16,13 @@
>  #include "sha256.h"
>  #include "../boot/string.h"
>  
> -unsigned long purgatory_backup_dest;
> -unsigned long purgatory_backup_src;
> -unsigned long purgatory_backup_sz;
> +unsigned long purgatory_backup_dest __section(.kexec-purgatory);
> +unsigned long purgatory_backup_src __section(.kexec-purgatory);
> +unsigned long purgatory_backup_sz __section(.kexec-purgatory);
>  
> -u8 purgatory_sha256_digest[SHA256_DIGEST_SIZE];
> +u8 purgatory_sha256_digest[SHA256_DIGEST_SIZE] __section(.kexec-purgatory);
>  
> -struct kexec_sha_region purgatory_sha_regions[KEXEC_SEGMENT_MAX];
> +struct kexec_sha_region purgatory_sha_regions[KEXEC_SEGMENT_MAX] __section(.kexec-purgatory);
>  
>  /*
>   * On x86, second kernel requries first 640K of memory to boot. Copy
>

Thread

kexec, x86/purgatory: Cleanup the unholy mess Thomas Gleixner <tglx@linutronix.de> - 2017-03-10 13:20 +0100
  Re: kexec, x86/purgatory: Cleanup the unholy mess Mike Galbraith <efault@gmx.de> - 2017-03-10 14:50 +0100
    Re: kexec, x86/purgatory: Cleanup the unholy mess Thomas Gleixner <tglx@linutronix.de> - 2017-03-10 15:00 +0100
      Re: kexec, x86/purgatory: Cleanup the unholy mess Vivek Goyal <vgoyal@redhat.com> - 2017-03-10 15:30 +0100
        Re: kexec, x86/purgatory: Cleanup the unholy mess Thomas Gleixner <tglx@linutronix.de> - 2017-03-10 16:00 +0100
          Re: kexec, x86/purgatory: Cleanup the unholy mess Vivek Goyal <vgoyal@redhat.com> - 2017-03-10 16:10 +0100
      Re: kexec, x86/purgatory: Cleanup the unholy mess Mike Galbraith <efault@gmx.de> - 2017-03-10 15:40 +0100
        Re: kexec, x86/purgatory: Cleanup the unholy mess Mike Galbraith <efault@gmx.de> - 2017-03-10 16:00 +0100
          Re: kexec, x86/purgatory: Cleanup the unholy mess Thomas Gleixner <tglx@linutronix.de> - 2017-03-10 16:40 +0100
            Re: kexec, x86/purgatory: Cleanup the unholy mess Mike Galbraith <efault@gmx.de> - 2017-03-10 19:20 +0100
        Re: kexec, x86/purgatory: Cleanup the unholy mess Thomas Gleixner <tglx@linutronix.de> - 2017-03-10 16:00 +0100
  [tip:x86/urgent] kexec, x86/purgatory: Unbreak it and clean it up tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2017-03-10 21:20 +0100

csiph-web