Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1597901

Re: kexec, x86/purgatory: Cleanup the unholy mess

From Thomas Gleixner <tglx@linutronix.de>
Newsgroups linux.kernel
Subject Re: kexec, x86/purgatory: Cleanup the unholy mess
Date 2017-03-10 16:00 +0100
Message-ID <tjubn-5v7-15@gated-at.bofh.it> (permalink)
References <tjrGA-3S0-97@gated-at.bofh.it> <tjt5F-4JP-49@gated-at.bofh.it> <tjtfl-4NB-49@gated-at.bofh.it> <tjtIn-5ge-39@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Fri, 10 Mar 2017, Vivek Goyal wrote:
> I think we probably will have to initialize these global variables in
> purgatory itself and that puts them in .data section and relocation
> works.
> 
> That's how the code was intially. I initialized value of
> purgatory_sha256_digest in the code and then did "readelf -a purgatory.o"
> and symbol section index changed from COM to 3.
> 
> 13: 0000000000000000    32 OBJECT  GLOBAL DEFAULT    3
> purgatory_sha256_digest
> 
> [ 3] .data             PROGBITS         0000000000000000  00000120
>          0000000000000020  0000000000000000  WA       0     0     32

Yeah, and then instead of doing it proper you relied on compiler/link magic
which is unreliable, undocumented and uncomprehensible. But that's just
compatible to the rest of kexec. Works for me is never a good engineering
principle.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

kexec, x86/purgatory: Cleanup the unholy mess Thomas Gleixner <tglx@linutronix.de> - 2017-03-10 13:20 +0100
  Re: kexec, x86/purgatory: Cleanup the unholy mess Mike Galbraith <efault@gmx.de> - 2017-03-10 14:50 +0100
    Re: kexec, x86/purgatory: Cleanup the unholy mess Thomas Gleixner <tglx@linutronix.de> - 2017-03-10 15:00 +0100
      Re: kexec, x86/purgatory: Cleanup the unholy mess Vivek Goyal <vgoyal@redhat.com> - 2017-03-10 15:30 +0100
        Re: kexec, x86/purgatory: Cleanup the unholy mess Thomas Gleixner <tglx@linutronix.de> - 2017-03-10 16:00 +0100
          Re: kexec, x86/purgatory: Cleanup the unholy mess Vivek Goyal <vgoyal@redhat.com> - 2017-03-10 16:10 +0100
      Re: kexec, x86/purgatory: Cleanup the unholy mess Mike Galbraith <efault@gmx.de> - 2017-03-10 15:40 +0100
        Re: kexec, x86/purgatory: Cleanup the unholy mess Mike Galbraith <efault@gmx.de> - 2017-03-10 16:00 +0100
          Re: kexec, x86/purgatory: Cleanup the unholy mess Thomas Gleixner <tglx@linutronix.de> - 2017-03-10 16:40 +0100
            Re: kexec, x86/purgatory: Cleanup the unholy mess Mike Galbraith <efault@gmx.de> - 2017-03-10 19:20 +0100
        Re: kexec, x86/purgatory: Cleanup the unholy mess Thomas Gleixner <tglx@linutronix.de> - 2017-03-10 16:00 +0100
  [tip:x86/urgent] kexec, x86/purgatory: Unbreak it and clean it up tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2017-03-10 21:20 +0100

csiph-web