Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1598117

Re: z3fold: suspicious return with spinlock held

Show all headers | View raw

On Sat, Mar 11, 2017 at 12:22:12AM +0300, Alexey Khoroshilov wrote:
> Hello!
> 
> z3fold_reclaim_page() contains the only return that may
> leave the function with pool->lock spinlock held.
> 
> 669 	spin_lock(&pool->lock);
> 670 	if (kref_put(&zhdr->refcount, release_z3fold_page)) {
> 671 		atomic64_dec(&pool->pages_nr);
> 672 		return 0;
> 673 	}
> 
> May be we need spin_unlock(&pool->lock); just before return?

I would tend to agree.  sparse warns about this, and also about two
other locking problems ... which I'm not sure are really problems so
much as missing annotations?

mm/z3fold.c:467:35: warning: context imbalance in 'z3fold_alloc' - unexpected unlock
mm/z3fold.c:519:26: warning: context imbalance in 'z3fold_free' - different lock contexts for basic block
mm/z3fold.c:581:12: warning: context imbalance in 'z3fold_reclaim_page' - different lock contexts for basic block

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

z3fold: suspicious return with spinlock held Alexey Khoroshilov <khoroshilov@ispras.ru> - 2017-03-10 22:30 +0100
  Re: z3fold: suspicious return with spinlock held Matthew Wilcox <willy@infradead.org> - 2017-03-10 22:40 +0100
    Re: z3fold: suspicious return with spinlock held Alexey Khoroshilov <khoroshilov@ispras.ru> - 2017-03-10 23:00 +0100
      Re: z3fold: suspicious return with spinlock held vitalywool@gmail.com - 2017-03-10 23:10 +0100

csiph-web