z3fold: suspicious return with spinlock held

From	Alexey Khoroshilov <khoroshilov@ispras.ru>
Newsgroups	linux.kernel
Subject	z3fold: suspicious return with spinlock held
Date	2017-03-10 22:30 +0100
Message-ID	<tjAgO-1eI-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello!

z3fold_reclaim_page() contains the only return that may
leave the function with pool->lock spinlock held.

669 	spin_lock(&pool->lock);
670 	if (kref_put(&zhdr->refcount, release_z3fold_page)) {
671 		atomic64_dec(&pool->pages_nr);
672 		return 0;
673 	}

May be we need spin_unlock(&pool->lock); just before return?


Found by Linux Driver Verification project (linuxtesting.org).

--
Thank you,
Alexey Khoroshilov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

z3fold: suspicious return with spinlock held Alexey Khoroshilov <khoroshilov@ispras.ru> - 2017-03-10 22:30 +0100
  Re: z3fold: suspicious return with spinlock held Matthew Wilcox <willy@infradead.org> - 2017-03-10 22:40 +0100
    Re: z3fold: suspicious return with spinlock held Alexey Khoroshilov <khoroshilov@ispras.ru> - 2017-03-10 23:00 +0100
      Re: z3fold: suspicious return with spinlock held vitalywool@gmail.com - 2017-03-10 23:10 +0100

csiph-web