Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1594463
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/3] staging: sm750fb: Alignment should match open parenthesis |
| Date | 2017-03-07 18:50 +0100 |
| Message-ID | <tirpg-2s0-21@gated-at.bofh.it> (permalink) |
| References | <thCwq-7VQ-11@gated-at.bofh.it> <thCwq-7VQ-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sun, Mar 05, 2017 at 04:54:50PM +0530, Arushi Singhal wrote:
> @@ -147,18 +146,18 @@ static int programModeRegisters(mode_parameter_t *pModeParam,
> PANEL_HORIZONTAL_SYNC_START_MASK));
>
> poke32(PANEL_VERTICAL_TOTAL,
> - (((pModeParam->vertical_total - 1) <<
> - PANEL_VERTICAL_TOTAL_TOTAL_SHIFT) &
> - PANEL_VERTICAL_TOTAL_TOTAL_MASK) |
> - ((pModeParam->vertical_display_end - 1) &
> - PANEL_VERTICAL_TOTAL_DISPLAY_END_MASK));
> + (((pModeParam->vertical_total - 1) <<
> + PANEL_VERTICAL_TOTAL_TOTAL_SHIFT) &
> + PANEL_VERTICAL_TOTAL_TOTAL_MASK) |
> + ((pModeParam->vertical_display_end - 1) &
> + ANEL_VERTICAL_TOTAL_DISPLAY_END_MASK));
^^^^
Missing P in PANEL means this won't compile.
>
> poke32(PANEL_VERTICAL_SYNC,
> - ((pModeParam->vertical_sync_height <<
> - PANEL_VERTICAL_SYNC_HEIGHT_SHIFT) &
> - PANEL_VERTICAL_SYNC_HEIGHT_MASK) |
> - ((pModeParam->vertical_sync_start - 1) &
> - PANEL_VERTICAL_SYNC_START_MASK));
> + ((pModeParam->vertical_sync_height <<
> + PANEL_VERTICAL_SYNC_HEIGHT_SHIFT) &
> + PANEL_VERTICAL_SYNC_HEIGHT_MASK) |
> + ((pModeParam->vertical_sync_start - 1) &
> + PANEL_VERTICAL_SYNC_START_MASK));
>
> tmp = DISPLAY_CTRL_TIMING | DISPLAY_CTRL_PLANE;
> if (pModeParam->vertical_sync_polarity)
regards,
dan carpenter
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/3] multiple checkpatch issues Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-05 12:30 +0100
[PATCH 3/3] staging: sm750fb: Alignment should match open parenthesis Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-05 12:30 +0100
Re: [PATCH 3/3] staging: sm750fb: Alignment should match open parenthesis Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-07 18:50 +0100
[PATCH 1/3] staging: sm750fb: fixes add blank line after function/struct/union/enum declarations Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-05 12:30 +0100
Re: [PATCH 1/3] staging: sm750fb: fixes add blank line after function/struct/union/enum declarations Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-06 20:40 +0100
Re: [PATCH 1/3] staging: sm750fb: fixes add blank line after function/struct/union/enum declarations Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-07 18:50 +0100
[PATCH 2/3] staging: sm750fb: function prototype argument should have an identifier name Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-05 12:30 +0100
Re: [PATCH 0/3] multiple checkpatch issues Joe Perches <joe@perches.com> - 2017-03-05 15:00 +0100
csiph-web