Re: [PATCH 1/3] staging: sm750fb: fixes add blank line after function/struct/union/enum declarations

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] staging: sm750fb: fixes add blank line after function/struct/union/enum declarations
Date	2017-03-07 18:50 +0100
Message-ID	<tirpg-2s0-13@gated-at.bofh.it> (permalink)
References	<thCwq-7VQ-11@gated-at.bofh.it> <thCwq-7VQ-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Mar 05, 2017 at 04:54:48PM +0530, Arushi Singhal wrote:
> This patch fixes the warnings reported by checkpatch.pl
> for please use a blank line after function/struct/union/enum
> declarations.
> 
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
>  drivers/staging/sm750fb/ddk750_display.h | 1 +
>  drivers/staging/sm750fb/ddk750_mode.h    | 2 ++
>  drivers/staging/sm750fb/ddk750_power.h   | 1 +
>  drivers/staging/sm750fb/sm750_cursor.c   | 3 +++
>  4 files changed, 7 insertions(+)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_display.h b/drivers/staging/sm750fb/ddk750_display.h
> index e2a3f84ca4c5..8bf22e4f0d8b 100644
> --- a/drivers/staging/sm750fb/ddk750_display.h
> +++ b/drivers/staging/sm750fb/ddk750_display.h
> @@ -100,6 +100,7 @@ typedef enum _disp_output_t {
>  	do_CRT_PRI = CRT_2_PRI | PRI_TP_ON | DPMS_ON | DAC_ON,
>  	do_CRT_SEC = CRT_2_SEC | SEC_TP_ON | DPMS_ON | DAC_ON,
>  }
> +
>  disp_output_t;


Nah...  This is a typedef and this change makes it even worse.  It
should be on the same line as the }.

} disp_output_t;

But actually this typedef is not allowed.

regards,
dan carpenter

Thread

[PATCH 0/3] multiple checkpatch issues Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-05 12:30 +0100
  [PATCH 3/3] staging: sm750fb: Alignment should match open parenthesis Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-05 12:30 +0100
    Re: [PATCH 3/3] staging: sm750fb: Alignment should match open  parenthesis Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-07 18:50 +0100
  [PATCH 1/3] staging: sm750fb: fixes add blank line after function/struct/union/enum declarations Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-05 12:30 +0100
    Re: [PATCH 1/3] staging: sm750fb: fixes add blank line after  function/struct/union/enum declarations Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-06 20:40 +0100
    Re: [PATCH 1/3] staging: sm750fb: fixes add blank line after  function/struct/union/enum declarations Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-07 18:50 +0100
  [PATCH 2/3] staging: sm750fb: function prototype argument should have an identifier name Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-05 12:30 +0100
  Re: [PATCH 0/3] multiple checkpatch issues Joe Perches <joe@perches.com> - 2017-03-05 15:00 +0100

csiph-web