Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1594364
| Path | csiph.com!1.us.feeder.erje.net!2.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Arnaldo Carvalho de Melo <acme@kernel.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 02/23] perf buildid-cache: Add -q/--quiet option |
| Date | Tue, 07 Mar 2017 16:40:03 +0100 |
| Message-ID | <tipnt-152-35@gated-at.bofh.it> (permalink) |
| References | <tip46-X4-13@gated-at.bofh.it> <tipnt-152-37@gated-at.bofh.it> |
| X-Original-To | Namhyung Kim <namhyung@kernel.org> |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| X-URL | http://acmel.wordpress.com |
| User-Agent | Mutt/1.7.1 (2016-10-04) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 24 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>, kernel-team@lge.com |
| X-Original-Date | Tue, 7 Mar 2017 12:28:30 -0300 |
| X-Original-Message-ID | <20170307152830.GB7670@kernel.org> |
| X-Original-References | <20170307150851.22304-1-namhyung@kernel.org> <20170307150851.22304-3-namhyung@kernel.org> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1594364 |
Show key headers only | View raw
Em Wed, Mar 08, 2017 at 12:08:30AM +0900, Namhyung Kim escreveu:
> The -q/--quiet option is to suppress any message. Sometimes users just
> want to run the command and it can be used for that case.
<SNIP>
> +++ b/tools/perf/builtin-buildid-cache.c
> @@ -311,6 +311,7 @@ int cmd_buildid_cache(int argc, const char **argv,
> OPT_INCR('v', "verbose", &verbose, "be more verbose"),
> + OPT_BOOLEAN('q', "quiet", &quiet, "Do not show any message"),
> OPT_END()
> };
> const char * const buildid_cache_usage[] = {
> @@ -326,6 +327,9 @@ int cmd_buildid_cache(int argc, const char **argv,
>
> + if (quiet)
> + perf_quiet_option();
> +
Hey, I see that this is done lots of times, can't we use that parent
option stuff? Or some fallback we can have in perf's main() for thing
like this?
- Arnaldo
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH 02/23] perf buildid-cache: Add -q/--quiet option Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-07 16:40 +0100 Re: [PATCH 02/23] perf buildid-cache: Add -q/--quiet option Namhyung Kim <namhyung@kernel.org> - 2017-03-07 18:30 +0100
csiph-web