Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1594364

Re: [PATCH 02/23] perf buildid-cache: Add -q/--quiet option

Show all headers | View raw

Em Wed, Mar 08, 2017 at 12:08:30AM +0900, Namhyung Kim escreveu:
> The -q/--quiet option is to suppress any message.  Sometimes users just
> want to run the command and it can be used for that case.

<SNIP>

> +++ b/tools/perf/builtin-buildid-cache.c
> @@ -311,6 +311,7 @@ int cmd_buildid_cache(int argc, const char **argv,
>  	OPT_INCR('v', "verbose", &verbose, "be more verbose"),
> +	OPT_BOOLEAN('q', "quiet", &quiet, "Do not show any message"),
>  	OPT_END()
>  	};
>  	const char * const buildid_cache_usage[] = {
> @@ -326,6 +327,9 @@ int cmd_buildid_cache(int argc, const char **argv,
>  
> +	if (quiet)
> +		perf_quiet_option();
> +

Hey, I see that this is done lots of times, can't we use that parent
option stuff? Or some fallback we can have in perf's main() for thing
like this?

- Arnaldo

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 02/23] perf buildid-cache: Add -q/--quiet option Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-07 16:40 +0100
  Re: [PATCH 02/23] perf buildid-cache: Add -q/--quiet option Namhyung Kim <namhyung@kernel.org> - 2017-03-07 18:30 +0100

csiph-web