Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1594138

Re: [PATCH v2 3/7] PCI: dwc: artpec6: Populate cpu_addr_fixup ops

Show all headers | View raw

Às 9:52 AM de 3/7/2017, Kishon Vijay Abraham I escreveu:
> Populate cpu_addr_fixup ops to extract the least 28 bits of the
> corresponding cpu address.
> 
> Cc: Niklas Cassel <niklas.cassel@axis.com>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  drivers/pci/dwc/pcie-artpec6.c |   15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/pci/dwc/pcie-artpec6.c b/drivers/pci/dwc/pcie-artpec6.c
> index fcd3ef8..5b3b3af 100644
> --- a/drivers/pci/dwc/pcie-artpec6.c
> +++ b/drivers/pci/dwc/pcie-artpec6.c
> @@ -78,6 +78,11 @@ static void artpec6_pcie_writel(struct artpec6_pcie *artpec6_pcie, u32 offset, u
>  	regmap_write(artpec6_pcie->regmap, offset, val);
>  }
>  
> +static u64 artpec6_pcie_cpu_addr_fixup(u64 pci_addr)
> +{
> +	return pci_addr & ARTPEC6_CPU_TO_BUS_ADDR;
> +}
> +
>  static int artpec6_pcie_establish_link(struct artpec6_pcie *artpec6_pcie)
>  {
>  	struct dw_pcie *pci = artpec6_pcie->pci;
> @@ -142,11 +147,6 @@ static int artpec6_pcie_establish_link(struct artpec6_pcie *artpec6_pcie)
>  	 */
>  	dw_pcie_writel_dbi(pci, MISC_CONTROL_1_OFF, DBI_RO_WR_EN);
>  
> -	pp->io_base &= ARTPEC6_CPU_TO_BUS_ADDR;
> -	pp->mem_base &= ARTPEC6_CPU_TO_BUS_ADDR;
> -	pp->cfg0_base &= ARTPEC6_CPU_TO_BUS_ADDR;
> -	pp->cfg1_base &= ARTPEC6_CPU_TO_BUS_ADDR;
> -
>  	/* setup root complex */
>  	dw_pcie_setup_rc(pp);
>  
> @@ -234,6 +234,10 @@ static int artpec6_add_pcie_port(struct artpec6_pcie *artpec6_pcie,
>  	return 0;
>  }
>  
> +static const struct dw_pcie_ops dw_pcie_ops = {
> +	.cpu_addr_fixup = artpec6_pcie_cpu_addr_fixup,
> +};
> +
>  static int artpec6_pcie_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
> @@ -252,6 +256,7 @@ static int artpec6_pcie_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  
>  	pci->dev = dev;
> +	pci->ops = &dw_pcie_ops;
>  
>  	artpec6_pcie->pci = pci;
>  
> 

Simpler, no doubt.

Acked-By: Joao Pinto <jpinto@synopsys.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/7] PCI: dwc: miscellaneous fixes and cleanups Kishon Vijay Abraham I <kishon@ti.com> - 2017-03-07 11:00 +0100
  [PATCH v2 1/7] PCI: dwc: designware: Add new *ops* for cpu addr fixup Kishon Vijay Abraham I <kishon@ti.com> - 2017-03-07 11:00 +0100
    Re: [PATCH v2 1/7] PCI: dwc: designware: Add new *ops* for cpu addr  fixup Joao Pinto <Joao.Pinto@synopsys.com> - 2017-03-07 12:20 +0100
  [PATCH v2 4/7] PCI: dwc: all: Modify dbi accessors to take dbi_base as argument Kishon Vijay Abraham I <kishon@ti.com> - 2017-03-07 11:00 +0100
    Re: [PATCH v2 4/7] PCI: dwc: all: Modify dbi accessors to take  dbi_base as argument Joao Pinto <Joao.Pinto@synopsys.com> - 2017-03-07 13:30 +0100
  [PATCH v2 2/7] PCI: dwc: dra7xx: Populate cpu_addr_fixup ops Kishon Vijay Abraham I <kishon@ti.com> - 2017-03-07 11:00 +0100
    Re: [PATCH v2 2/7] PCI: dwc: dra7xx: Populate cpu_addr_fixup ops Joao Pinto <Joao.Pinto@synopsys.com> - 2017-03-07 12:30 +0100
  [PATCH v2 3/7] PCI: dwc: artpec6: Populate cpu_addr_fixup ops Kishon Vijay Abraham I <kishon@ti.com> - 2017-03-07 11:00 +0100
    Re: [PATCH v2 3/7] PCI: dwc: artpec6: Populate cpu_addr_fixup ops Joao Pinto <Joao.Pinto@synopsys.com> - 2017-03-07 12:30 +0100
  [PATCH v2 6/7] PCI: dwc: designware: Modify _unroll() to _ob_unroll() Kishon Vijay Abraham I <kishon@ti.com> - 2017-03-07 11:10 +0100
  Re: [PATCH v2 5/7] PCI: dwc: all: Modify dbi accessors to access data  of 4/2/1 bytes Kishon Vijay Abraham I <kishon@ti.com> - 2017-03-07 12:30 +0100
  Re: [PATCH v2 5/7] PCI: dwc: all: Modify dbi accessors to access data  of 4/2/1 bytes Joao Pinto <Joao.Pinto@synopsys.com> - 2017-03-07 15:30 +0100
  [PATCH v2 5/7] PCI: dwc: all: Modify dbi accessors to access data of 4/2/1  bytes Kishon Vijay Abraham I <kishon@ti.com> - 2017-03-08 19:40 +0100

csiph-web