Re: [PATCH] mm,hugetlb: compute page_size_log properly

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Andi Kleen <ak@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm,hugetlb: compute page_size_log properly
Date	Wed, 08 Mar 2017 20:40:01 +0100
Message-ID	<tiPBf-2As-3@gated-at.bofh.it> (permalink)
References	<tiNg6-18z-13@gated-at.bofh.it>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.36,265,1486454400"; d="scan'208";a="73209035"
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.7.1 (2016-10-04)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	21
Organization	linux.* mail to news gateway
X-Original-Cc	akpm@linux-foundation.org, mhocko@suse.com, mtk.manpages@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de>
X-Original-Date	Wed, 8 Mar 2017 11:39:00 -0800
X-Original-Message-ID	<20170308193900.GC32070@tassilo.jf.intel.com>
X-Original-References	<1488992761-9464-1-git-send-email-dave@stgolabs.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1595465

Show key headers only | View raw

> One example of the problems with extra layers what this patch fixes:
> mmap_pgoff() should never be using SHM_HUGE_* logic. This was
> introduced by:
> 
>    091d0d55b28 (shm: fix null pointer deref when userspace specifies invalid hugepage size)
> 
> It is obviously harmless but lets just rip out the whole thing --
> the shmget.2 manpage will need updating, as it should not be
> describing kernel internals.

The SHM_* defines were supposed to be exported to user space,
but somehow they didn't make it into uapi.

But something like this is useful, it's a much nicer 
interface for users than to hard code the bit position

So I would rather if you move it to uapi instead of 
removing. What the kernel uses internally doesn't
really matter.

-Andi

Thread

[PATCH] mm,hugetlb: compute page_size_log properly Davidlohr Bueso <dave@stgolabs.net> - 2017-03-08 18:10 +0100
  Re: [PATCH] mm,hugetlb: compute page_size_log properly Andi Kleen <ak@linux.intel.com> - 2017-03-08 20:40 +0100
    Re: [PATCH] mm,hugetlb: compute page_size_log properly Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-03-09 04:30 +0100
  Re: [PATCH] mm,hugetlb: compute page_size_log properly Michal Hocko <mhocko@kernel.org> - 2017-03-09 10:20 +0100

csiph-web