Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1595465

Re: [PATCH] mm,hugetlb: compute page_size_log properly

Show all headers | View raw

> One example of the problems with extra layers what this patch fixes:
> mmap_pgoff() should never be using SHM_HUGE_* logic. This was
> introduced by:
> 
>    091d0d55b28 (shm: fix null pointer deref when userspace specifies invalid hugepage size)
> 
> It is obviously harmless but lets just rip out the whole thing --
> the shmget.2 manpage will need updating, as it should not be
> describing kernel internals.

The SHM_* defines were supposed to be exported to user space,
but somehow they didn't make it into uapi.

But something like this is useful, it's a much nicer 
interface for users than to hard code the bit position

So I would rather if you move it to uapi instead of 
removing. What the kernel uses internally doesn't
really matter.

-Andi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm,hugetlb: compute page_size_log properly Davidlohr Bueso <dave@stgolabs.net> - 2017-03-08 18:10 +0100
  Re: [PATCH] mm,hugetlb: compute page_size_log properly Andi Kleen <ak@linux.intel.com> - 2017-03-08 20:40 +0100
    Re: [PATCH] mm,hugetlb: compute page_size_log properly Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-03-09 04:30 +0100
  Re: [PATCH] mm,hugetlb: compute page_size_log properly Michal Hocko <mhocko@kernel.org> - 2017-03-09 10:20 +0100

csiph-web