[PATCH 08/26] IB/ocrdma: Improve size determinations in ocrdma_mbx_rdma_stats()

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	[PATCH 08/26] IB/ocrdma: Improve size determinations in ocrdma_mbx_rdma_stats()
Date	Wed, 08 Mar 2017 14:20:01 +0100
Message-ID	<tiJFv-73D-3@gated-at.bofh.it> (permalink)
References	<tiJct-6C3-9@gated-at.bofh.it>
X-Original-To	linux-rdma@vger.kernel.org, Devesh Sharma <devesh.sharma@avagotech.com>, Doug Ledford <dledford@redhat.com>, Hal Rosenstock <hal.rosenstock@gmail.com>, Sean Hefty <sean.hefty@intel.com>, Selvin Xavier <selvin.xavier@avagotech.com>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Transfer-Encoding	7bit
X-Provags-ID	V03:K0:l3N2YWMPpUujLrmXLrF7Gi1zgq8GpcHePFN6BhwzXW8lrOZXHPb +KtytQm/OUwgok/2N0T4sGmN8obhllto8syj/hrXpqY+bWWf2XGK1IpGa1zCAaYtvJXP+yZ S///5iB7LKK9Gbzjty1SOPzOTwPyk+UlKC+X7YSjW/ORTpNX2QqDnKp8AUrkm8djXr0kkLX SPrO2SvcnPuqWit5qaViw==
X-Ui-Out-Filterresults	notjunk:1;V01:K0:l5gfDVbrJZs=:726p0eXui8YvKI2kWwtGDI M9R9fuFvzzHRBlfPVpyLsVRXqJTZpnKVWdQc+8g04GUndCV/F0r+DxxHHJaCFgwZyAoVKeNiz zbzxFwWBs0bYYKtbxpawn4Q0orkMJafz0Tx9jb73PIYo2KF5Z5dSFW6qlTRglDfTffCoXVNoq knWZH4oNIVa3KQ6g7iHz1L9ntlZqtRTYe84US5k8wRepwMnVxTooYyG9IA4/nYIeFA410NWlV tILNzjuFx+w/Wo4W6U5a7oUwDQMAQVa4hdkei4uojnmAHbMPy9NrLOMhaD05Uj+D+4PIgpqV1 6E66n6ZD4ncbqlcABFFn2SybdB1czJZr27W2bBR5BzjFwNdbKfPGldoesV0sKb4P3kkGKlYhe U0BRE0pXZ730T0OkaO2m0dKSiJe6yDlRqGidHRqrgENN6czPPlfggTjFK+0BUcM7onjpmSXTe rsadIE55axBOSLO5QLjV7+0B/s4kBaNcJt8s5XYWTqMpVV5cnCTTdHoGFj4/IxsGG+iH6etCe M48XlVKxfv+SU+rB8+XFYvibFOMy8qgyt85eQhe9dS8hwctCcR0KjvZU0pKL2SZ+gkNVXHssl 5qOf+GNV3p70as3eGpPBD6YUUaqxfhiVSLtVkbal6bD7fQEb7UStf/xAk1vvwORfK25mxe2rY IF8Qf7SxLqzQFjVsr1w2JtXvuvaAu14EdGQ3bO0lomBAkcrBYAjHJSD9kAIkmiFsuPNIc6Kit r7/7lZyXHFzFzmx/+8J4TW3yq8HaRCtJI3bJPg9Oaoy0qqtZh3cx+BGuXeXhd4tGebhUUCpXv 9lssU3F
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
X-Original-Cc	LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
X-Original-Date	Wed, 8 Mar 2017 13:58:49 +0100
X-Original-Message-ID	<b72381fc-8ffd-ba40-45d3-2d3f8fb2e224@users.sourceforge.net>
X-Original-References	<fc421509-4069-da8a-b308-60b49ea91ada@users.sourceforge.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1595153

Show key headers only | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 7 Mar 2017 20:16:16 +0100

Replace the specification of two data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determinations a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
index 1f7d88d7569e..0628600bee56 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
@@ -1302,7 +1302,7 @@ int ocrdma_mbx_rdma_stats(struct ocrdma_dev *dev, bool reset)
 	mqe->u.nonemb_req.sge[0].len = dev->stats_mem.size;
 
 	/* Cache the old stats */
-	memcpy(old_stats, req, sizeof(struct ocrdma_rdma_stats_resp));
+	memcpy(old_stats, req, sizeof(*old_stats));
 	memset(req, 0, dev->stats_mem.size);
 
 	ocrdma_init_mch((struct ocrdma_mbx_hdr *)req,
@@ -1315,7 +1315,7 @@ int ocrdma_mbx_rdma_stats(struct ocrdma_dev *dev, bool reset)
 	status = ocrdma_nonemb_mbx_cmd(dev, mqe, dev->stats_mem.va);
 	if (status)
 		/* Copy from cache, if mbox fails */
-		memcpy(req, old_stats, sizeof(struct ocrdma_rdma_stats_resp));
+		memcpy(req, old_stats, sizeof(*old_stats));
 	else
 		ocrdma_le32_to_cpu(req, dev->stats_mem.size);
 
-- 
2.12.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 08/26] IB/ocrdma: Improve size determinations in  ocrdma_mbx_rdma_stats() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-03-08 14:20 +0100
  Re: [PATCH 08/26] IB/ocrdma: Improve size determinations in  ocrdma_mbx_rdma_stats() Yuval Shaia <yuval.shaia@oracle.com> - 2017-03-08 15:30 +0100

csiph-web