[PATCH 09/26] IB/ocrdma: Improve another size determination in ocrdma_mq_cq_handler()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	[PATCH 09/26] IB/ocrdma: Improve another size determination in ocrdma_mq_cq_handler()
Date	2017-03-08 14:20 +0100
Message-ID	<tiJFv-73D-1@gated-at.bofh.it> (permalink)
References	<tiJct-6C3-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 7 Mar 2017 20:20:45 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
index 0628600bee56..7d1e1caa90de 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
@@ -890,7 +890,7 @@ static int ocrdma_mq_cq_handler(struct ocrdma_dev *dev, u16 cq_id)
 			ocrdma_process_acqe(dev, cqe);
 		else if (cqe->valid_ae_cmpl_cons & OCRDMA_MCQE_CMPL_MASK)
 			ocrdma_process_mcqe(dev, cqe);
-		memset(cqe, 0, sizeof(struct ocrdma_mcqe));
+		memset(cqe, 0, sizeof(*cqe));
 		ocrdma_mcq_inc_tail(dev);
 	}
 	ocrdma_ring_cq_db(dev, dev->mq.cq.id, true, false, cqe_popped);
-- 
2.12.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 09/26] IB/ocrdma: Improve another size determination in  ocrdma_mq_cq_handler() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-03-08 14:20 +0100
  Re: [PATCH 09/26] IB/ocrdma: Improve another size determination in  ocrdma_mq_cq_handler() Yuval Shaia <yuval.shaia@oracle.com> - 2017-03-08 15:30 +0100

csiph-web