Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1594870

Re: [PATCH 2/2] Staging: comedi: comedi_fops: Fix "out of minor numbers for board device files"

Path csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] Staging: comedi: comedi_fops: Fix "out of minor numbers for board device files"
Date Wed, 08 Mar 2017 07:00:01 +0100
Message-ID <tiCNH-237-9@gated-at.bofh.it> (permalink)
References <thnxn-5re-11@gated-at.bofh.it> <thnxn-5re-9@gated-at.bofh.it>
X-Original-To Cheah Kok Cheong <thrust73@gmail.com>
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.5.21 (2010-09-15)
X-Source-IP aserv0022.oracle.com [141.146.126.234]
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 12
Organization linux.* mail to news gateway
X-Original-Cc abbotti@mev.co.uk, hsweeten@visionengravers.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
X-Original-Date Wed, 8 Mar 2017 08:54:47 +0300
X-Original-Message-ID <20170307195149.GA10722@mwanda>
X-Original-References <cd5f3e9f6320ac0063e61f0d0457e5400091390c.1488654618.git.thrust73@gmail.com> <b96cfe8f8b63ff70d8bc3c34bff24ea0fbfc191d.1488654618.git.thrust73@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1594870

Show key headers only | View raw


On Sun, Mar 05, 2017 at 03:22:33AM +0800, Cheah Kok Cheong wrote:
> If comedi module is loaded with the following max allowed parameter
> [comedi_num_legacy_minors=48], subsequent loading of an auto-configured
> device will fail.

Don't set comedi_num_legacy_minors=48, then?

This doesn't seem like the right fix at all.  Why only allow one auto
configured board?  Why not 5 or 10?

regards,
dan carpenter

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] Staging: comedi: comedi_fops: Change comedi_num_legacy_minors type Cheah Kok Cheong <thrust73@gmail.com> - 2017-03-04 20:30 +0100
  [PATCH 2/2] Staging: comedi: comedi_fops: Fix "out of minor numbers for board device files" Cheah Kok Cheong <thrust73@gmail.com> - 2017-03-04 20:30 +0100
    Re: [PATCH 2/2] Staging: comedi: comedi_fops: Fix "out of minor  numbers for board device files" Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-08 07:00 +0100
      Re: [PATCH 2/2] Staging: comedi: comedi_fops: Fix "out of minor  numbers for board device files" Cheah Kok Cheong <thrust73@gmail.com> - 2017-03-08 11:20 +0100
        Re: [PATCH 2/2] Staging: comedi: comedi_fops: Fix "out of minor  numbers for board device files" Ian Abbott <abbotti@mev.co.uk> - 2017-03-08 12:20 +0100
          Re: [PATCH 2/2] Staging: comedi: comedi_fops: Fix "out of minor  numbers for board device files" Cheah Kok Cheong <thrust73@gmail.com> - 2017-03-08 18:10 +0100
  Re: [PATCH 1/2] Staging: comedi: comedi_fops: Change  comedi_num_legacy_minors type Greg KH <gregkh@linuxfoundation.org> - 2017-03-07 20:10 +0100
    Re: [PATCH 1/2] Staging: comedi: comedi_fops: Change  comedi_num_legacy_minors type Greg KH <gregkh@linuxfoundation.org> - 2017-03-08 11:20 +0100
      Re: [PATCH 1/2] Staging: comedi: comedi_fops: Change  comedi_num_legacy_minors type Cheah Kok Cheong <thrust73@gmail.com> - 2017-03-08 11:20 +0100
    Re: [PATCH 1/2] Staging: comedi: comedi_fops: Change  comedi_num_legacy_minors type Cheah Kok Cheong <thrust73@gmail.com> - 2017-03-08 11:40 +0100

csiph-web