Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1595010

Re: [PATCH 2/2] Staging: comedi: comedi_fops: Fix "out of minor numbers for board device files"

Show all headers | View raw

Dear Dan,
  Thanks for reviewing this patch.

On Wed, Mar 08, 2017 at 08:54:47AM +0300, Dan Carpenter wrote:
> On Sun, Mar 05, 2017 at 03:22:33AM +0800, Cheah Kok Cheong wrote:
> > If comedi module is loaded with the following max allowed parameter
> > [comedi_num_legacy_minors=48], subsequent loading of an auto-configured
> > device will fail.
> 
> Don't set comedi_num_legacy_minors=48, then?
> 
> This doesn't seem like the right fix at all.  Why only allow one auto
> configured board?  Why not 5 or 10?
> 

Let me explain, the original intended behaviour is to allow user to
reserve up to 48 minor numbers for legacy devices.

Therefore [sudo modprobe comedi comedi_num_legacy_minors=3] 
will allocate minor number 0, 1, 2 for legacy devices.
Subsequent loading of an auto-configured device will use minor number 3.
And the next one number 4 so on and so forth.

Now for the corner case of [comedi_num_legacy_minors=48] which
is supposed to reserve minor number 0 till 47 for legacy devices,
and is supposed to allocate number 48 and so on for auto-configured
devices, does not allocate number 48 anymore after commit
38b9722a4414.

This is due to the changes in comedi_alloc_board_minor().

As to why I chose to limit [comedi_num_legacy_minors=47], is given
in the commit log.

This will allow user to allocate 0 till 46 for legacy devices and
subsequent auto-configured devices will start from 47 and so forth.

I don't think anybody will miss one less number for legacy devices
otherwise there'll be complains earlier on.

Thanks.

Brgds,
CheahKC 

> regards,
> dan carpenter
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] Staging: comedi: comedi_fops: Change comedi_num_legacy_minors type Cheah Kok Cheong <thrust73@gmail.com> - 2017-03-04 20:30 +0100
  [PATCH 2/2] Staging: comedi: comedi_fops: Fix "out of minor numbers for board device files" Cheah Kok Cheong <thrust73@gmail.com> - 2017-03-04 20:30 +0100
    Re: [PATCH 2/2] Staging: comedi: comedi_fops: Fix "out of minor  numbers for board device files" Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-08 07:00 +0100
      Re: [PATCH 2/2] Staging: comedi: comedi_fops: Fix "out of minor  numbers for board device files" Cheah Kok Cheong <thrust73@gmail.com> - 2017-03-08 11:20 +0100
        Re: [PATCH 2/2] Staging: comedi: comedi_fops: Fix "out of minor  numbers for board device files" Ian Abbott <abbotti@mev.co.uk> - 2017-03-08 12:20 +0100
          Re: [PATCH 2/2] Staging: comedi: comedi_fops: Fix "out of minor  numbers for board device files" Cheah Kok Cheong <thrust73@gmail.com> - 2017-03-08 18:10 +0100
  Re: [PATCH 1/2] Staging: comedi: comedi_fops: Change  comedi_num_legacy_minors type Greg KH <gregkh@linuxfoundation.org> - 2017-03-07 20:10 +0100
    Re: [PATCH 1/2] Staging: comedi: comedi_fops: Change  comedi_num_legacy_minors type Greg KH <gregkh@linuxfoundation.org> - 2017-03-08 11:20 +0100
      Re: [PATCH 1/2] Staging: comedi: comedi_fops: Change  comedi_num_legacy_minors type Cheah Kok Cheong <thrust73@gmail.com> - 2017-03-08 11:20 +0100
    Re: [PATCH 1/2] Staging: comedi: comedi_fops: Change  comedi_num_legacy_minors type Cheah Kok Cheong <thrust73@gmail.com> - 2017-03-08 11:40 +0100

csiph-web