Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1594854

Re: [PATCH 10/15] drm/sun4i: tcon: Switch mux on only for composite

From Stefan Monnier <monnier@iro.umontreal.ca>
Newsgroups linux.kernel
Subject Re: [PATCH 10/15] drm/sun4i: tcon: Switch mux on only for composite
Date 2017-03-08 06:00 +0100
Message-ID <tiBRE-1o7-25@gated-at.bofh.it> (permalink)
References <tiji2-5io-9@gated-at.bofh.it> <tijrI-5mG-15@gated-at.bofh.it> <tiB5f-12i-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


>> +       if (encoder->encoder_type == DRM_MODE_ENCODER_TVDAC)
>> +               val = 1;
>> +       else
>> +               val = 0;

Isn't this better written as

           val = (encoder->encoder_type == DRM_MODE_ENCODER_TVDAC);


-- Stefan

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/15] drm: sun4i: Add support for the HDMI controller Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-07 10:10 +0100
  [PATCH 11/15] drm/sun4i: tcon: Fix tcon channel 1 backporch calculation Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-07 10:20 +0100
    Re: [PATCH 11/15] drm/sun4i: tcon: Fix tcon channel 1 backporch calculation Chen-Yu Tsai <wens@csie.org> - 2017-03-08 05:40 +0100
      Re: [PATCH 11/15] drm/sun4i: tcon: Fix tcon channel 1 backporch  calculation Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-08 23:00 +0100
  [PATCH 10/15] drm/sun4i: tcon: Switch mux on only for composite Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-07 10:20 +0100
    Re: [PATCH 10/15] drm/sun4i: tcon: Switch mux on only for composite Chen-Yu Tsai <wens@csie.org> - 2017-03-08 05:10 +0100
      Re: [PATCH 10/15] drm/sun4i: tcon: Switch mux on only for composite Stefan Monnier <monnier@iro.umontreal.ca> - 2017-03-08 06:00 +0100
      Re: [PATCH 10/15] drm/sun4i: tcon: Switch mux on only for composite Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-09 12:00 +0100
        Re: [linux-sunxi] Re: [PATCH 10/15] drm/sun4i: tcon: Switch mux on  only for composite Chen-Yu Tsai <wens@csie.org> - 2017-03-09 12:40 +0100
          Re: [linux-sunxi] Re: [PATCH 10/15] drm/sun4i: tcon: Switch mux on  only for composite Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-09 16:00 +0100
  [PATCH 8/15] drm/sun4i: tcon: Add channel debug Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-07 10:20 +0100
    Re: [PATCH 8/15] drm/sun4i: tcon: Add channel debug Chen-Yu Tsai <wens@csie.org> - 2017-03-08 05:00 +0100
  [PATCH 9/15] drm/sun4i: tcon: Pass the encoder to the mode set functions Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-07 10:20 +0100
  [PATCH 15/15] ARM: sun5i: a10s-olinuxino: Enable HDMI Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-07 10:20 +0100
    Re: [PATCH 15/15] ARM: sun5i: a10s-olinuxino: Enable HDMI Chen-Yu Tsai <wens@csie.org> - 2017-03-08 04:50 +0100
  [PATCH 14/15] ARM: sun5i: a10s: Add the HDMI controller node Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-07 10:30 +0100
    Re: [linux-sunxi] [PATCH 14/15] ARM: sun5i: a10s: Add the HDMI  controller node Chen-Yu Tsai <wens@csie.org> - 2017-03-08 05:10 +0100
      Re: [linux-sunxi] [PATCH 14/15] ARM: sun5i: a10s: Add the HDMI  controller node Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-09 12:10 +0100
        Re: [linux-sunxi] [PATCH 14/15] ARM: sun5i: a10s: Add the HDMI  controller node Chen-Yu Tsai <wens@csie.org> - 2017-03-09 12:20 +0100
  [PATCH 2/15] clk: sunxi-ng: Pass the parent and a pointer to the clocks round rate Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-07 10:40 +0100
  [PATCH 1/15] clk: divider: Make divider_round_rate take the parent clock Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-07 10:40 +0100
    Re: [PATCH 1/15] clk: divider: Make divider_round_rate take the  parent clock Stephen Boyd <sboyd@codeaurora.org> - 2017-03-07 15:20 +0100
      Re: [PATCH 1/15] clk: divider: Make divider_round_rate take the  parent clock Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-09 12:20 +0100
  [PATCH 12/15] drm/sun4i: tcon: multiply the vtotal when not in interlace Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-07 10:40 +0100
    Re: [PATCH 12/15] drm/sun4i: tcon: multiply the vtotal when not in interlace Chen-Yu Tsai <wens@csie.org> - 2017-03-07 11:10 +0100
      Re: [PATCH 12/15] drm/sun4i: tcon: multiply the vtotal when not in  interlace Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-09 12:20 +0100
  [PATCH 13/15] drm/sun4i: Add HDMI support Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-07 10:40 +0100
  [PATCH 7/15] dt-bindings: display: sun4i: Add allwinner,tcon-channel property Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-07 10:40 +0100
    Re: [PATCH 7/15] dt-bindings: display: sun4i: Add allwinner,tcon-channel  property Chen-Yu Tsai <wens@csie.org> - 2017-03-08 04:50 +0100
  [PATCH 6/15] dt-bindings: display: sun4i: Add HDMI display bindings Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-07 10:40 +0100
    Re: [PATCH 6/15] dt-bindings: display: sun4i: Add HDMI display bindings Chen-Yu Tsai <wens@csie.org> - 2017-03-08 04:50 +0100

csiph-web