Path: csiph.com!1.us.feeder.erje.net!2.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From: Stefan Monnier <monnier@iro.umontreal.ca>
Newsgroups: linux.kernel
Subject: Re: [PATCH 10/15] drm/sun4i: tcon: Switch mux on only for composite
Date: Wed, 08 Mar 2017 06:00:02 +0100
Message-ID: <tiBRE-1o7-25@gated-at.bofh.it>
References: <tiji2-5io-9@gated-at.bofh.it> <tijrI-5mG-15@gated-at.bofh.it> <tiB5f-12i-1@gated-at.bofh.it>
X-Injected-Via-Gmane: http://gmane.org/
Lines: 11
MIME-Version: 1.0
Content-Type: text/plain
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)
Cancel-Lock: sha1:+NQyHOoIhhiwhuREIwrIx/7Wu1k=
Sender: robomod@news.nic.it
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Approved: robomod@news.nic.it
Organization: linux.* mail to news gateway
X-Original-Cc: linux-sunxi@googlegroups.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
X-Original-Cc: linux-sunxi@googlegroups.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
X-Original-Cc: linux-sunxi@googlegroups.com, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
X-Original-Date: Tue, 07 Mar 2017 23:16:59 -0500
X-Original-Message-ID: <jwvmvcwflnm.fsf-monnier+gmane.comp.hardware.netbook.arm.sunxi@gnu.org>
X-Original-References: <cover.bc06ffa88f847ddd9ddd7c259415d5f61b55307b.1488876832.git-series.maxime.ripard@free-electrons.com> <3f70bcfe2ec03188c06d54a262d49ad91963a510.1488876832.git-series.maxime.ripard@free-electrons.com> <CAGb2v67iTOV-=u5rReu6_wi6NFoCoJkbJKshTpmFYUmJ=ggKUw@mail.gmail.com>
X-Original-Sender: linux-kernel-owner@vger.kernel.org
X-Original-X-Complaints-To: usenet@blaine.gmane.org
Xref: csiph.com linux.kernel:1594854

>> +       if (encoder->encoder_type == DRM_MODE_ENCODER_TVDAC)
>> +               val = 1;
>> +       else
>> +               val = 0;

Isn't this better written as

           val = (encoder->encoder_type == DRM_MODE_ENCODER_TVDAC);


-- Stefan