Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1592403

Re: [PATCH] staging: ks7010: clean up code

From Ernestas Kulik <ernestas.kulik@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] staging: ks7010: clean up code
Date 2017-03-04 07:50 +0100
Message-ID <thbFT-4UE-3@gated-at.bofh.it> (permalink)
References <th2CB-6TT-5@gated-at.bofh.it> <th6Gd-1bu-3@gated-at.bofh.it> <thbmx-4GL-1@gated-at.bofh.it> <thbwd-4O7-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, 2017-03-03 at 22:37-0800, Joe Perches wrote:
>
> struct hostif_hdr.event is declared at uint16_t
> and not as __le16 so I believe this is incorrect
> and actually introduces a sparse error.

Sure, but I change that in the patch. :)

On Sat, 2017-03-04 at 08:28 +0200, Ernestas Kulik wrote:
>
> struct hostif_hdr {
>-	uint16_t size;
>-	uint16_t event;
>+	__le16 size;
>+	__le16 event;
> } __packed;

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] staging: ks7010: clean up code Ernestas Kulik <ernestas.kulik@gmail.com> - 2017-03-03 22:10 +0100
  Re: [PATCH] staging: ks7010: clean up code Joe Perches <joe@perches.com> - 2017-03-04 02:30 +0100
    Re: [PATCH] staging: ks7010: clean up code Ernestas Kulik <ernestas.kulik@gmail.com> - 2017-03-04 07:30 +0100
      Re: [PATCH] staging: ks7010: clean up code Joe Perches <joe@perches.com> - 2017-03-04 07:40 +0100
        Re: [PATCH] staging: ks7010: clean up code Ernestas Kulik <ernestas.kulik@gmail.com> - 2017-03-04 07:50 +0100
          Re: [PATCH] staging: ks7010: clean up code Joe Perches <joe@perches.com> - 2017-03-04 08:30 +0100
            Re: [PATCH] staging: ks7010: clean up code Ernestas Kulik <ernestas.kulik@gmail.com> - 2017-03-04 10:20 +0100

csiph-web