Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1592371
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] staging: ks7010: clean up code |
| Date | 2017-03-04 02:30 +0100 |
| Message-ID | <th6Gd-1bu-3@gated-at.bofh.it> (permalink) |
| References | <th2CB-6TT-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 2017-03-03 at 22:58 +0200, Ernestas Kulik wrote:
> This fixes type warnings generated by sparse, replaces instances of
> ntohs() with be16_to_cpu() and removes unused fields in structs.
There's no real need to convert ntohs to be16_to_cpu
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
[]
>
> @@ -297,7 +297,8 @@ static int write_to_device(struct ks_wlan_private *priv, unsigned char *buffer,
> hdr = (struct hostif_hdr *)buffer;
>
> DPRINTK(4, "size=%d\n", hdr->size);
> - if (hdr->event < HIF_DATA_REQ || HIF_REQ_MAX < hdr->event) {
> + if (le16_to_cpu(hdr->event) < HIF_DATA_REQ ||
> + HIF_REQ_MAX < le16_to_cpu(hdr->event)) {
>
This isn't mentioned and doesn't match the commit message
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] staging: ks7010: clean up code Ernestas Kulik <ernestas.kulik@gmail.com> - 2017-03-03 22:10 +0100
Re: [PATCH] staging: ks7010: clean up code Joe Perches <joe@perches.com> - 2017-03-04 02:30 +0100
Re: [PATCH] staging: ks7010: clean up code Ernestas Kulik <ernestas.kulik@gmail.com> - 2017-03-04 07:30 +0100
Re: [PATCH] staging: ks7010: clean up code Joe Perches <joe@perches.com> - 2017-03-04 07:40 +0100
Re: [PATCH] staging: ks7010: clean up code Ernestas Kulik <ernestas.kulik@gmail.com> - 2017-03-04 07:50 +0100
Re: [PATCH] staging: ks7010: clean up code Joe Perches <joe@perches.com> - 2017-03-04 08:30 +0100
Re: [PATCH] staging: ks7010: clean up code Ernestas Kulik <ernestas.kulik@gmail.com> - 2017-03-04 10:20 +0100
csiph-web