Re: [PATCH] ARM: dts: exynos: Add power button for Odroid XU3/4

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news2.arglkargh.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Brian Kim <brian.kim@hardkernel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: dts: exynos: Add power button for Odroid XU3/4
Date	Mon, 06 Mar 2017 11:00:02 +0100
Message-ID	<thXAS-6lr-9@gated-at.bofh.it> (permalink)
References	<thRc6-1Dq-13@gated-at.bofh.it> <thVIJ-50B-7@gated-at.bofh.it>
X-Original-To	Krzysztof Kozlowski <krzk@kernel.org>
X-Hm-Ut	PO5rMHMNchGKORqWqpptcxU6TO9ReridPci7IJn7j7w=
Authentication-Results	mail-smtp-vm28; auth=pass (plain) smtp.auth=brian3321
X-Originating-IP	115.90.78.142
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Transfer-Encoding	8bit
X-Hm-Figure	B6N4k3uJpk416+PmSLMxQh7BhLtvAO7c
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	43
Organization	linux.* mail to news gateway
X-Original-Cc	linux.amoon@gmail.com, Łukasz Majewski <l.majewski@samsung.com>, robh+dt@kernel.org, kgene@kernel.org, mark.rutland@arm.com, Javier Martinez Canillas <javier@osg.samsung.com>, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
X-Original-Date	Mon, 6 Mar 2017 18:49:43 +0900
X-Original-Message-ID	<ae78c84d-796b-609b-ba00-c253a1f63a84@hardkernel.com>
X-Original-References	<1488768729-9435-1-git-send-email-brian.kim@hardkernel.com> <CAJKOXPcwzy_hAMLoUNcJxYHjHfUF+YmeqSLPy2spvyCwck=TaA@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1593138

Show key headers only | View raw

On 2017년 03월 06일 16:24, Krzysztof Kozlowski wrote:
> On Mon, Mar 6, 2017 at 4:52 AM, Brian Kim <brian.kim@hardkernel.com> wrote:
>> The power button on Odroid XU3/4 is connected with the PWRON pin of
>> s2mps11 PMIC. The s2mps11 sends low signal to GPIO input in exynos 5422
>> via ONOB pin.
>>
>> This patch adds devicetree bindings for the power button of Odroid
>> XU3/4.
>>
>> Signed-off-by: Brian Kim <brian.kim@hardkernel.com>
>> ---
>>  arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 22 ++++++++++++++++++++++
>>  1 file changed, 22 insertions(+)
>>
> Hi,
>
> Thanks for the patch.
>
> You sent almost the same patch as Anand did some time ago (with few
> missing things) :
> https://patchwork.kernel.org/patch/8388491/
I'm sorry, Krzysztof. I haven't seen it before.

When I checked git log history in the kernel source, this patch was missed.
So, I submitted it.

>
> All previous comments apply, including that you added a key for gpx0-3
> which is not a PWRON and it does not match description at all.
Yes, gpx0-3 is not PWRON.
PWRON is the 5V power input signal generated by the SW2 push button on Odroid-Xu3/4 boards

(active high). PWRON notifies "power up event to start" to s2mps13 PMIC.

gpx0-3 in Exynos 5422 is connected to the ONOB pin of PMIC.
According to s2mps13 datasheet, ONOB operates as 'PWRON key active low signal'.
s2mps13 PMIC generates the opposite signal from the PWRON via ONOB (active low).
So, we can get the state of power button by gpx0-3.

>
> Best regards,
> Krzysztof
>

Thread

[PATCH] ARM: dts: exynos: Add power button for Odroid XU3/4 Brian Kim <brian.kim@hardkernel.com> - 2017-03-06 04:10 +0100
  Re: [PATCH] ARM: dts: exynos: Add power button for Odroid XU3/4 Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-06 09:00 +0100
    Re: [PATCH] ARM: dts: exynos: Add power button for Odroid XU3/4 Brian Kim <brian.kim@hardkernel.com> - 2017-03-06 11:00 +0100
      Re: [PATCH] ARM: dts: exynos: Add power button for Odroid XU3/4 Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-07 22:20 +0100

csiph-web