Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1592980

Re: [PATCH] ARM: dts: exynos: Add power button for Odroid XU3/4

Show all headers | View raw

On Mon, Mar 6, 2017 at 4:52 AM, Brian Kim <brian.kim@hardkernel.com> wrote:
> The power button on Odroid XU3/4 is connected with the PWRON pin of
> s2mps11 PMIC. The s2mps11 sends low signal to GPIO input in exynos 5422
> via ONOB pin.
>
> This patch adds devicetree bindings for the power button of Odroid
> XU3/4.
>
> Signed-off-by: Brian Kim <brian.kim@hardkernel.com>
> ---
>  arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>

Hi,

Thanks for the patch.

You sent almost the same patch as Anand did some time ago (with few
missing things) :
https://patchwork.kernel.org/patch/8388491/

All previous comments apply, including that you added a key for gpx0-3
which is not a PWRON and it does not match description at all.

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: dts: exynos: Add power button for Odroid XU3/4 Brian Kim <brian.kim@hardkernel.com> - 2017-03-06 04:10 +0100
  Re: [PATCH] ARM: dts: exynos: Add power button for Odroid XU3/4 Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-06 09:00 +0100
    Re: [PATCH] ARM: dts: exynos: Add power button for Odroid XU3/4 Brian Kim <brian.kim@hardkernel.com> - 2017-03-06 11:00 +0100
      Re: [PATCH] ARM: dts: exynos: Add power button for Odroid XU3/4 Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-07 22:20 +0100

csiph-web