Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1592878

Re: [PATCH v2 3/3] ARM: dts: bcm5301x: Add I2C support to the DT

Path csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From Florian Fainelli <f.fainelli@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 3/3] ARM: dts: bcm5301x: Add I2C support to the DT
Date Mon, 06 Mar 2017 02:30:01 +0100
Message-ID <thPDj-ro-5@gated-at.bofh.it> (permalink)
References <tgJqh-1AZ-15@gated-at.bofh.it> <tgSjT-849-5@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=SMo4kPL2Gz2gRpjSpnXr56fDMG+wJlj3StcFA7P1lT0=; b=jIYQ1NlNhDohpf5N1Bq8Y+vyCO8eoNMGYNstbRVAydodCp1Y2Gl9+wK4pRWUKKIdBc bFkphLEj2befwNGWaNGsDV7bYiPx9hGIa8N9QYjJriQpKaY9UxzdYEvd3h3V8hIGk0OY 9XjwbhDA8QiQLgL+e2Z3HnXoHeDOSJVFXFLUy1uceFae9mcn1MvLxuyztWfKLcyt4Iyc /C4GyDOacG51+6Evg0X4VfoVzqh2rorhenOOXShk0z6Ndq1lXM24Dh2uN3TlYthpR9Lb JTSwzWJ0ic31/udq1EjtXK+93d66IKZYt+gx3KGNM5rilkuWFKck5H4ldvp683LQ2Fcp dE2Q==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=SMo4kPL2Gz2gRpjSpnXr56fDMG+wJlj3StcFA7P1lT0=; b=JD0wSvpNw9lh2wrJGtq2BbgB7XgwQu/txz5O8OpxXF4b9Wjisi4oP0zUepaseiBsTC 2SwvMwLrQgz0XlR6RAPiPBxQyL/7ildd2aQePaeklQpf4e8cprEv8kkDxLwoakU+Hk1W WnKljapnbgbz2DR/Yi/RY3yZlbZ9jgptHcwBtIH0owVxZtBiDDYznNtK66aqS/uhshBS LW5/rVnPCRWebWaiUmVSLb4N/V1b5+VdB4cQaqTIQalomM2bNjIr1LtINt0V/tYu2Drk F6o1TXg9RvQkdw+dw072EatepO8+Ga4SagpT+wBAxl6S9paZV710k1lURV4pU2N5inLb MMEA==
X-Gm-Message-State AMke39lSWFKIN5A8t/jMmWaBNRSsG1wPei75U6wesuL+fjmifKlVUReq0ZsH/2eIHXP8RQ==
X-Received by 10.237.57.164 with SMTP id m33mr14471349qte.293.1488762817304; Sun, 05 Mar 2017 17:13:37 -0800 (PST)
User-Agent Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0
MIME-Version 1.0
Content-Type text/plain; charset=windows-1252
Content-Transfer-Encoding 7bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 45
Organization linux.* mail to news gateway
X-Original-Cc Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Florian Fainelli <f.fainelli@gmail.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Jon Mason <jonmason@broadcom.com>
X-Original-Date Sun, 5 Mar 2017 17:13:34 -0800
X-Original-Message-ID <bb91cbbd-f5e5-9ce8-e925-89e6f831e50c@gmail.com>
X-Original-References <1488500494-20622-1-git-send-email-jon.mason@broadcom.com> <1488500494-20622-4-git-send-email-jon.mason@broadcom.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1592878

Show key headers only | View raw



On 03/02/2017 04:21 PM, Jon Mason wrote:
> From: Jon Mason <jonmason@broadcom.com>
> 
> Add I2C support to the bcm5301x Device Tree.  Since no driver changes
> are needed to enable this hardware, only the device tree changes are
> required to make this functional.
> 
> Signed-off-by: Jon Mason <jonmason@broadcom.com>
> ---
>  arch/arm/boot/dts/bcm5301x.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
> index 4e3fbce..2a343f2 100644
> --- a/arch/arm/boot/dts/bcm5301x.dtsi
> +++ b/arch/arm/boot/dts/bcm5301x.dtsi
> @@ -338,6 +338,15 @@
>  		};
>  	};
>  
> +	i2c0: i2c@18009000 {
> +		compatible = "brcm,iproc-i2c";
> +		reg = <0x18009000 0x50>;
> +		interrupts = <GIC_SPI 121 IRQ_TYPE_NONE>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		clock-frequency = <100000>;

Should not this have a:
		status = "disabled"

property by default such that boards can override this by phandle when
there are actual I2C devices available?

> +	};
> +
>  	lcpll0: lcpll0@1800c100 {
>  		#clock-cells = <1>;
>  		compatible = "brcm,nsp-lcpll0";
> 

-- 
Florian

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/3] ARM: dts: BCM5301X: GIC_PPI bug, TWD WD and i2c Support Jon Mason <jon.mason@broadcom.com> - 2017-03-03 01:40 +0100
  [PATCH v2 2/3] ARM: dts: bcm5301x: Add TWD WD Support to DT Jon Mason <jon.mason@broadcom.com> - 2017-03-03 02:30 +0100
  [PATCH v2 3/3] ARM: dts: bcm5301x: Add I2C support to the DT Jon Mason <jon.mason@broadcom.com> - 2017-03-03 11:10 +0100
    Re: [PATCH v2 3/3] ARM: dts: bcm5301x: Add I2C support to the DT Florian Fainelli <f.fainelli@gmail.com> - 2017-03-06 02:30 +0100
      Re: [PATCH v2 3/3] ARM: dts: bcm5301x: Add I2C support to the DT Jon Mason <jon.mason@broadcom.com> - 2017-03-06 16:50 +0100

csiph-web