Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1592878

Re: [PATCH v2 3/3] ARM: dts: bcm5301x: Add I2C support to the DT

From Florian Fainelli <f.fainelli@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 3/3] ARM: dts: bcm5301x: Add I2C support to the DT
Date 2017-03-06 02:30 +0100
Message-ID <thPDj-ro-5@gated-at.bofh.it> (permalink)
References <tgJqh-1AZ-15@gated-at.bofh.it> <tgSjT-849-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw



On 03/02/2017 04:21 PM, Jon Mason wrote:
> From: Jon Mason <jonmason@broadcom.com>
> 
> Add I2C support to the bcm5301x Device Tree.  Since no driver changes
> are needed to enable this hardware, only the device tree changes are
> required to make this functional.
> 
> Signed-off-by: Jon Mason <jonmason@broadcom.com>
> ---
>  arch/arm/boot/dts/bcm5301x.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
> index 4e3fbce..2a343f2 100644
> --- a/arch/arm/boot/dts/bcm5301x.dtsi
> +++ b/arch/arm/boot/dts/bcm5301x.dtsi
> @@ -338,6 +338,15 @@
>  		};
>  	};
>  
> +	i2c0: i2c@18009000 {
> +		compatible = "brcm,iproc-i2c";
> +		reg = <0x18009000 0x50>;
> +		interrupts = <GIC_SPI 121 IRQ_TYPE_NONE>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		clock-frequency = <100000>;

Should not this have a:
		status = "disabled"

property by default such that boards can override this by phandle when
there are actual I2C devices available?

> +	};
> +
>  	lcpll0: lcpll0@1800c100 {
>  		#clock-cells = <1>;
>  		compatible = "brcm,nsp-lcpll0";
> 

-- 
Florian

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/3] ARM: dts: BCM5301X: GIC_PPI bug, TWD WD and i2c Support Jon Mason <jon.mason@broadcom.com> - 2017-03-03 01:40 +0100
  [PATCH v2 2/3] ARM: dts: bcm5301x: Add TWD WD Support to DT Jon Mason <jon.mason@broadcom.com> - 2017-03-03 02:30 +0100
  [PATCH v2 3/3] ARM: dts: bcm5301x: Add I2C support to the DT Jon Mason <jon.mason@broadcom.com> - 2017-03-03 11:10 +0100
    Re: [PATCH v2 3/3] ARM: dts: bcm5301x: Add I2C support to the DT Florian Fainelli <f.fainelli@gmail.com> - 2017-03-06 02:30 +0100
      Re: [PATCH v2 3/3] ARM: dts: bcm5301x: Add I2C support to the DT Jon Mason <jon.mason@broadcom.com> - 2017-03-06 16:50 +0100

csiph-web