Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1590467

Re: [PATCH 01/20] PCI: remove __weak tag from pci_remap_iospace()

Show all headers | View raw

On Mon, Feb 27, 2017 at 4:14 PM, Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
> pci_remap_iospace() is marked as a weak symbol even though
> no architecture is currently overriding it; given that its
> implementation internals have already code paths that are
> arch specific (ie PCI_IOBASE and ioremap_page_range() attributes)
> there is no need to leave the weak symbol in the kernel since the
> same functionality can be achieved by customizing per-arch the
> corresponding functionality.
>
> Remove the __weak symbol from pci_remap_iospace().

Good idea,

Acked-by: Arnd Bergmann <arnd@arndb.de>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/20] PCI: fix config and I/O Address space memory mappings Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-02-27 16:20 +0100
  [PATCH 17/20] PCI: xgene: update PCI config space remap function Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-02-27 16:20 +0100
  [PATCH 03/20] asm-generic/io.h: add PCI config space remap interface Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-02-27 16:20 +0100
  [PATCH 15/20] PCI: designware: update PCI config space remap function Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-02-27 16:20 +0100
  [PATCH 04/20] ARM64: implement pci_remap_cfgspace() interface Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-02-27 16:20 +0100
  [PATCH 14/20] PCI: hisi: update PCI config space remap function Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-02-27 16:20 +0100
    RE: [PATCH 14/20] PCI: hisi: update PCI config space remap function Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2017-03-02 12:00 +0100
      RE: [PATCH 14/20] PCI: hisi: update PCI config space remap function Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2017-03-02 13:00 +0100
      Re: [PATCH 14/20] PCI: hisi: update PCI config space remap function Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-03-02 18:40 +0100
  [PATCH 01/20] PCI: remove __weak tag from pci_remap_iospace() Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-02-27 16:30 +0100
    Re: [PATCH 01/20] PCI: remove __weak tag from pci_remap_iospace() Arnd Bergmann <arnd@arndb.de> - 2017-03-01 17:20 +0100
  [PATCH 05/20] ARM: implement pci_remap_cfgspace() interface Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-02-27 16:30 +0100
  [PATCH 08/20] PCI: xilinx: update PCI config space remap function Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-02-27 16:30 +0100
  [PATCH 10/20] PCI: spear13xx: update PCI config space remap function Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-02-27 16:30 +0100
  [PATCH 06/20] PCI: ECAM: use pci_remap_cfgspace() to map config region Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-02-27 16:30 +0100
  [PATCH 07/20] PCI: implement Devres interface to map PCI config space Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-02-27 16:30 +0100
    Re: [PATCH 07/20] PCI: implement Devres interface to map PCI config  space Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-02-28 11:50 +0100
    Re: [PATCH 07/20] PCI: implement Devres interface to map PCI config space Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-02 03:10 +0100
      Re: [PATCH 07/20] PCI: implement Devres interface to map PCI config  space Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-03-02 13:10 +0100
        Re: [PATCH 07/20] PCI: implement Devres interface to map PCI config space Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-02 14:30 +0100
          Re: [PATCH 07/20] PCI: implement Devres interface to map PCI config  space Thierry Reding <thierry.reding@gmail.com> - 2017-03-02 21:20 +0100
          Re: [PATCH 07/20] PCI: implement Devres interface to map PCI config  space Tejun Heo <tj@kernel.org> - 2017-03-03 00:20 +0100
  [PATCH 09/20] PCI: xilinx-nwl: update PCI config space remap function Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-02-27 16:30 +0100
  Re: [PATCH 00/20] PCI: fix config and I/O Address space memory mappings Arnd Bergmann <arnd@arndb.de> - 2017-03-01 17:30 +0100
    Re: [PATCH 00/20] PCI: fix config and I/O Address space memory  mappings Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-03-02 19:10 +0100

csiph-web