Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1592006

[PATCH 07/13] rtc: rtc-ds1672: Add OF device ID table

Show all headers | View raw

The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.

But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/rtc/rtc-ds1672.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-ds1672.c b/drivers/rtc/rtc-ds1672.c
index 5c18ac7394c4..7bf46bfe11a4 100644
--- a/drivers/rtc/rtc-ds1672.c
+++ b/drivers/rtc/rtc-ds1672.c
@@ -196,10 +196,17 @@ static struct i2c_device_id ds1672_id[] = {
 };
 MODULE_DEVICE_TABLE(i2c, ds1672_id);
 
+static const struct of_device_id ds1672_of_match[] = {
+	{ .compatible = "dallas,ds1672" },
+	{ }
+};
+MODULE_DEVICE_TABLE(of, ds1672_of_match);
+
 static struct i2c_driver ds1672_driver = {
 	.driver = {
 		   .name = "rtc-ds1672",
-		   },
+		   .of_match_table = of_match_ptr(ds1672_of_match),
+	},
 	.probe = &ds1672_probe,
 	.id_table = ds1672_id,
 };
-- 
2.9.3

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/13] rtc: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-03 15:40 +0100
  [PATCH 08/13] rtc: ds1374: Set .of_match_table to OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-03 15:40 +0100
  [PATCH 02/13] rtc: rv3029: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-03 15:40 +0100
  [PATCH 05/13] rtc: rx8010: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-03 15:40 +0100
  [PATCH 07/13] rtc: rtc-ds1672: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-03 15:40 +0100
  [PATCH 01/13] rtc: rv8803: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-03 15:40 +0100
  Re: [PATCH 00/13] rtc: Add OF device table to I2C drivers that are  missing it Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-03-03 16:20 +0100
    Re: [PATCH 00/13] rtc: Add OF device table to I2C drivers that are  missing it Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-03 16:50 +0100
      Re: [PATCH 00/13] rtc: Add OF device table to I2C drivers that are  missing it Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-03-03 17:30 +0100
        Re: [PATCH 00/13] rtc: Add OF device table to I2C drivers that are  missing it Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-03 18:20 +0100
  Re: [PATCH 00/13] rtc: Add OF device table to I2C drivers that are  missing it Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-03-09 04:40 +0100

csiph-web