Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1592004

[PATCH 05/13] rtc: rx8010: Add OF device ID table

Show all headers | View raw

The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.

But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/rtc/rtc-rx8010.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/rtc/rtc-rx8010.c b/drivers/rtc/rtc-rx8010.c
index d08da371912c..1ed3403ff8ac 100644
--- a/drivers/rtc/rtc-rx8010.c
+++ b/drivers/rtc/rtc-rx8010.c
@@ -59,6 +59,12 @@ static const struct i2c_device_id rx8010_id[] = {
 };
 MODULE_DEVICE_TABLE(i2c, rx8010_id);
 
+static const struct of_device_id rx8010_of_match[] = {
+	{ .compatible = "epson,rx8010" },
+	{ }
+};
+MODULE_DEVICE_TABLE(of, rx8010_of_match);
+
 struct rx8010_data {
 	struct i2c_client *client;
 	struct rtc_device *rtc;
@@ -487,6 +493,7 @@ static int rx8010_probe(struct i2c_client *client,
 static struct i2c_driver rx8010_driver = {
 	.driver = {
 		.name = "rtc-rx8010",
+		.of_match_table = of_match_ptr(rx8010_of_match),
 	},
 	.probe		= rx8010_probe,
 	.id_table	= rx8010_id,
-- 
2.9.3

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/13] rtc: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-03 15:40 +0100
  [PATCH 08/13] rtc: ds1374: Set .of_match_table to OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-03 15:40 +0100
  [PATCH 02/13] rtc: rv3029: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-03 15:40 +0100
  [PATCH 05/13] rtc: rx8010: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-03 15:40 +0100
  [PATCH 07/13] rtc: rtc-ds1672: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-03 15:40 +0100
  [PATCH 01/13] rtc: rv8803: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-03 15:40 +0100
  Re: [PATCH 00/13] rtc: Add OF device table to I2C drivers that are  missing it Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-03-03 16:20 +0100
    Re: [PATCH 00/13] rtc: Add OF device table to I2C drivers that are  missing it Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-03 16:50 +0100
      Re: [PATCH 00/13] rtc: Add OF device table to I2C drivers that are  missing it Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-03-03 17:30 +0100
        Re: [PATCH 00/13] rtc: Add OF device table to I2C drivers that are  missing it Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-03 18:20 +0100
  Re: [PATCH 00/13] rtc: Add OF device table to I2C drivers that are  missing it Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-03-09 04:40 +0100

csiph-web