Re: [PATCH 3/3] nvmem: core: Allow allocating several anonymous nvmem devices

From	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] nvmem: core: Allow allocating several anonymous nvmem devices
Date	2017-03-03 11:20 +0100
Message-ID	<tgStA-8ce-43@gated-at.bofh.it> (permalink)
References	<tgF3k-72m-7@gated-at.bofh.it> <tgF3l-72m-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 02/03/17 19:50, Alban wrote:
> Currently the nvmem core expect the config to provide a name and ID
> that are then used to create the device name. When no device name is
> given 'nvmem' is used. However if there is several such anonymous
> devices they all get named 'nvmem0', which doesn't work.
>
> To fix this problem use the ID from the config only when the config
> also provides a name. When no name is provided take the uinque ID of
> the nvmem device instead.
>
> Signed-off-by: Alban <albeu@free.fr>
> ---

Thanks for the Fix, looks good to me, I will queue this up once rc1 is out.


>  drivers/nvmem/core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index 408b521..8c830a8 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -468,7 +468,8 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)
>  	np = config->dev->of_node;
>  	nvmem->dev.of_node = np;
>  	dev_set_name(&nvmem->dev, "%s%d",
> -		     config->name ? : "nvmem", config->id);
> +		     config->name ? : "nvmem",
> +		     config->name ? config->id : nvmem->id);
>
>  	nvmem->read_only = of_property_read_bool(np, "read-only") |
>  			   config->read_only;
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] nvmem: core: Allow allocating several anonymous nvmem devices Alban <albeu@free.fr> - 2017-03-02 21:00 +0100
  Re: [PATCH 3/3] nvmem: core: Allow allocating several anonymous  nvmem devices Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-02 21:10 +0100
    Re: [PATCH 3/3] nvmem: core: Allow allocating several anonymous nvmem devices Moritz Fischer <mdf@kernel.org> - 2017-03-03 03:00 +0100
  Re: [PATCH 3/3] nvmem: core: Allow allocating several anonymous nvmem  devices Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2017-03-03 11:20 +0100

csiph-web