Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1591434

[PATCH 3/3] nvmem: core: Allow allocating several anonymous nvmem devices

Show all headers | View raw

Currently the nvmem core expect the config to provide a name and ID
that are then used to create the device name. When no device name is
given 'nvmem' is used. However if there is several such anonymous
devices they all get named 'nvmem0', which doesn't work.

To fix this problem use the ID from the config only when the config
also provides a name. When no name is provided take the uinque ID of
the nvmem device instead.

Signed-off-by: Alban <albeu@free.fr>
---
 drivers/nvmem/core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index 408b521..8c830a8 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -468,7 +468,8 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)
 	np = config->dev->of_node;
 	nvmem->dev.of_node = np;
 	dev_set_name(&nvmem->dev, "%s%d",
-		     config->name ? : "nvmem", config->id);
+		     config->name ? : "nvmem",
+		     config->name ? config->id : nvmem->id);
 
 	nvmem->read_only = of_property_read_bool(np, "read-only") |
 			   config->read_only;
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] nvmem: core: Allow allocating several anonymous nvmem devices Alban <albeu@free.fr> - 2017-03-02 21:00 +0100
  Re: [PATCH 3/3] nvmem: core: Allow allocating several anonymous  nvmem devices Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-02 21:10 +0100
    Re: [PATCH 3/3] nvmem: core: Allow allocating several anonymous nvmem devices Moritz Fischer <mdf@kernel.org> - 2017-03-03 03:00 +0100
  Re: [PATCH 3/3] nvmem: core: Allow allocating several anonymous nvmem  devices Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2017-03-03 11:20 +0100

csiph-web