Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer

From	SIMRAN SINGHAL <singhalsimran0@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer
Date	2017-03-02 23:10 +0100
Message-ID	<tgH58-85-21@gated-at.bofh.it> (permalink)
References	<tgGiK-80q-5@gated-at.bofh.it> <tgGsq-852-29@gated-at.bofh.it> <tgGLN-8cb-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Mar 3, 2017 at 3:13 AM, Joe Perches <joe@perches.com> wrote:
> On Fri, 2017-03-03 at 02:49 +0530, simran singhal wrote:
>> The following Coccinelle script was used to detect this:
>> @r@
>> expression x;
>> void* e;
>> type T;
>> identifier f;
>> @@
>> (
>>   *((T *)e)
>> >
>>
>>   ((T *)x)[...]
>> >
>>
>>   ((T*)x)->f
>> >
>>
>> - (T*)
>>   e
>> )
>
> NAK.
>
> Nice, but you still have to verify correctness
> before submitting these patches.
>
>> diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c b/drivers/staging/lustre/lustre/mgc/mgc_request.c
> []
>> @@ -1034,7 +1034,7 @@ static int mgc_set_info_async(const struct lu_env *env, struct obd_export *exp,
>>               rc = sptlrpc_parse_flavor(val, &flvr);
>>               if (rc) {
>>                       CERROR("invalid sptlrpc flavor %s to MGS\n",
>> -                            (char *)val);
>> +                            val);
>
> Try compiling this.
>

I compiled it before sending.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer simran singhal <singhalsimran0@gmail.com> - 2017-03-02 22:30 +0100
  Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on  void pointer Joe Perches <joe@perches.com> - 2017-03-02 22:50 +0100
    Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on  void pointer Joe Perches <joe@perches.com> - 2017-03-02 23:10 +0100
      Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on  void pointer Joe Perches <joe@perches.com> - 2017-03-02 23:20 +0100
      Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on  void pointer SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-03-02 23:40 +0100
        Re: [Outreachy kernel] Re: [PATCH 3/5] staging: lustre: lustre:  Remove unnecessary cast on void pointer Julia Lawall <julia.lawall@lip6.fr> - 2017-03-03 04:00 +0100
    Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on  void pointer SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-03-02 23:10 +0100

csiph-web