Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1591494

Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer

Show all headers | View raw

On Fri, 2017-03-03 at 02:49 +0530, simran singhal wrote:
> The following Coccinelle script was used to detect this:
> @r@
> expression x;
> void* e;
> type T;
> identifier f;
> @@
> (
>   *((T *)e)
> > 
> 
>   ((T *)x)[...]
> > 
> 
>   ((T*)x)->f
> > 
> 
> - (T*)
>   e
> )

NAK.

Nice, but you still have to verify correctness
before submitting these patches.

> diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c b/drivers/staging/lustre/lustre/mgc/mgc_request.c
[]
> @@ -1034,7 +1034,7 @@ static int mgc_set_info_async(const struct lu_env *env, struct obd_export *exp,
>  		rc = sptlrpc_parse_flavor(val, &flvr);
>  		if (rc) {
>  			CERROR("invalid sptlrpc flavor %s to MGS\n",
> -			       (char *)val);
> +			       val);

Try compiling this.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer simran singhal <singhalsimran0@gmail.com> - 2017-03-02 22:30 +0100
  Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on  void pointer Joe Perches <joe@perches.com> - 2017-03-02 22:50 +0100
    Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on  void pointer Joe Perches <joe@perches.com> - 2017-03-02 23:10 +0100
      Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on  void pointer Joe Perches <joe@perches.com> - 2017-03-02 23:20 +0100
      Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on  void pointer SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-03-02 23:40 +0100
        Re: [Outreachy kernel] Re: [PATCH 3/5] staging: lustre: lustre:  Remove unnecessary cast on void pointer Julia Lawall <julia.lawall@lip6.fr> - 2017-03-03 04:00 +0100
    Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on  void pointer SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-03-02 23:10 +0100

csiph-web