Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1590112

Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

Show all headers | View raw

On Wed, Mar 1, 2017 at 8:23 AM, Loh, Tien Hock <tien.hock.loh@intel.com> wrote:
> Arnd, Greg,

Please don't top-post.

> I checked the attributes returned by the soc attribute subsystem, but
> it seems that it is lacking something equivalent to timestamp in the
> Intel System ID controller. Do you think it is better to add a new
> attribute (named timestamp) to soc or create a new sysfs entry like
> what I did?

It depends on how common and how important this attribute is.

- if it's not overly important, just drop it entirely.
- if it's important enough that other SoCs are likely to have the same
  kind of information, make it a standard attribute
- if this SoC is most likely the only one that will ever need it, but it has
  important uses, I'd make it a custom attribute

Another option would be to fold the timestamp into the revision attribute,
but whether that is a reasonable place for it would in turn depend on
what the timestamp signifies.

Can you explain what the timestamp is used for? Does it identify the
time that the hardware revision was made, the time that a software
was built which was loaded into it, or something else?
What kind of user space application would need this information?

     Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver Greg KH <gregkh@linuxfoundation.org> - 2017-02-15 19:40 +0100
  Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver Arnd Bergmann <arnd@arndb.de> - 2017-02-15 21:00 +0100
    Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver "Loh, Tien Hock" <tien.hock.loh@intel.com> - 2017-02-23 07:10 +0100
      Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver "Loh, Tien Hock" <tien.hock.loh@intel.com> - 2017-02-23 09:20 +0100
        Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver "Loh, Tien Hock" <tien.hock.loh@intel.com> - 2017-03-01 08:40 +0100
          Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver Arnd Bergmann <arnd@arndb.de> - 2017-03-01 10:10 +0100
            Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver "Loh, Tien Hock" <tien.hock.loh@intel.com> - 2017-03-01 11:50 +0100
              Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver Arnd Bergmann <arnd@arndb.de> - 2017-03-01 12:50 +0100
                Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver "Loh, Tien Hock" <tien.hock.loh@intel.com> - 2017-03-02 03:20 +0100
      Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver Arnd Bergmann <arnd@arndb.de> - 2017-02-23 09:20 +0100
  Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver "Loh, Tien Hock" <tien.hock.loh@intel.com> - 2017-02-23 07:00 +0100

csiph-web