Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver
Date	2017-02-23 09:20 +0100
Message-ID	<tdWN4-731-23@gated-at.bofh.it> (permalink)
References	<tbcEG-3vT-33@gated-at.bofh.it> <tbcEG-3vT-31@gated-at.bofh.it> <tbdU5-4d3-9@gated-at.bofh.it> <tdULf-5DE-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Feb 23, 2017 at 6:58 AM, Loh, Tien Hock <tien.hock.loh@intel.com> wrote:
> On Rab, 2017-02-15 at 20:51 +0100, Arnd Bergmann wrote:
>> On Wed, Feb 15, 2017 at 6:17 PM, Greg KH <gregkh@linuxfoundation.org>
>> wrote:
>> >
>> > On Wed, Feb 15, 2017 at 07:09:41PM +0800, thloh wrote:
>> > >
>> > > From: "Loh, Tien Hock" <tien.hock.loh@intel.com>
>> > >
>> > > This patch is to add Altera System ID driver.
>> > > User can obtain the system ID and timestamp of the system by
>> > > reading the sysfs entry.
>> > >
>> > > Usage:
>> > > cat /sys/bus/platform/devices/[addr].sysid/sysid/id
>> > > cat /sys/bus/platform/devices/[addr].sysid/sysid/timestamp
>> > If you add new sysfs attributes, you need to also add a
>> > Documentation/ABI/ description as well.
>>
>> Maybe we could pretend that this is for a SoC and use the standard
>> soc_device
>> attributes as well as moving the driver into drivers/soc/?> Sorry for the late reply.
>
> This driver can currently be used by ARM and Nios II, so moving it into
> drivers/soc might not be the best idea.

Why not? drivers/soc/ was specifically introduced for stuff that is used on
some SoC but across more than one architecture (otherwise it would be
in arch/foo/). This seems to fit perfectly.

     Arnd

Thread

Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver Greg KH <gregkh@linuxfoundation.org> - 2017-02-15 19:40 +0100
  Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver Arnd Bergmann <arnd@arndb.de> - 2017-02-15 21:00 +0100
    Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver "Loh, Tien Hock" <tien.hock.loh@intel.com> - 2017-02-23 07:10 +0100
      Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver "Loh, Tien Hock" <tien.hock.loh@intel.com> - 2017-02-23 09:20 +0100
      Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver Arnd Bergmann <arnd@arndb.de> - 2017-02-23 09:20 +0100
  Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver "Loh, Tien Hock" <tien.hock.loh@intel.com> - 2017-02-23 07:00 +0100

csiph-web