Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1588717

Re: [Outreachy kernel] Re: [PATCH v2] staging: ks7010: remove code in comments.

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, 27 Feb 2017, Arushi Singhal wrote:

>
>
> On Mon, Feb 27, 2017 at 8:18 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
>       On Sun, Feb 26, 2017 at 09:38:20PM +0530, Arushi Singhal wrote:
>       > Commenting Code Is a Bad Idea.
>       > Comments are their to explain the code and how the code
>       achieves its
>       > goal and as codes in the comments  does not explain what the
>       code is
>       > doing so there is no use of commenting them.
>       > So in this patch codes in the comments are removed.
>       >
>       > Signed-off-by: Arushi Singhal
>       <arushisinghal19971997@gmail.com>
>       > ---
>       >  changes in v2
>       >  - subject lines is made short.
>       >
>       >  drivers/staging/ks7010/ks7010_sdio.c | 4 ----
>       >  1 file changed, 4 deletions(-)
>
>       This patch does not apply against my staging-testing branch :(
>
>
> why?

You should figure this out yourself.  Pull Greg's tree again, and try to
apply your patch.  It's deterministic, so you should have the same
information that he has.

julia

> Arushi
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF-7SfgGkcHGhraz2
> R%3D8qV4Vgqiky%2Bu%2BqSJNTMGr__JnTg%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] staging: ks7010: remove code in comments. Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-02-26 17:10 +0100
  Re: [PATCH v2] staging: ks7010: remove code in comments. Greg KH <gregkh@linuxfoundation.org> - 2017-02-27 15:50 +0100
    Re: [Outreachy kernel] Re: [PATCH v2] staging: ks7010: remove code  in comments. Julia Lawall <julia.lawall@lip6.fr> - 2017-02-27 16:10 +0100
      Re: [Outreachy kernel] Re: [PATCH v2] staging: ks7010: remove code  in comments. "Tobin C. Harding" <me@tobin.cc> - 2017-02-27 21:40 +0100

csiph-web