Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1588346

[PATCH v2] staging: ks7010: remove code in comments.

Show all headers | View raw

Commenting Code Is a Bad Idea.
Comments are their to explain the code and how the code achieves its
goal and as codes in the comments  does not explain what the code is
doing so there is no use of commenting them.
So in this patch codes in the comments are removed.

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
 changes in v2
 - subject lines is made short.

 drivers/staging/ks7010/ks7010_sdio.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index 2c263f98bdbb..54aa2e2f516f 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -495,10 +495,6 @@ static void ks7010_rw_function(struct work_struct *work)
 	/* wiat after WAKEUP */
 	while (time_after(priv->last_wakeup + ((30 * HZ) / 1000), jiffies)) {
 		DPRINTK(4, "wait after WAKEUP\n");
-/* 
- *   queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,&priv->ks_wlan_hw.rw_wq,
- *   (priv->last_wakeup + ((30*HZ)/1000) - jiffies));
- */
 		dev_info(&priv->ks_wlan_hw.sdio_card->func->dev,
 			 "wake: %lu %lu\n",
 			 priv->last_wakeup + (30 * HZ) / 1000,
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] staging: ks7010: remove code in comments. Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-02-26 17:10 +0100
  Re: [PATCH v2] staging: ks7010: remove code in comments. Greg KH <gregkh@linuxfoundation.org> - 2017-02-27 15:50 +0100
    Re: [Outreachy kernel] Re: [PATCH v2] staging: ks7010: remove code  in comments. Julia Lawall <julia.lawall@lip6.fr> - 2017-02-27 16:10 +0100
      Re: [Outreachy kernel] Re: [PATCH v2] staging: ks7010: remove code  in comments. "Tobin C. Harding" <me@tobin.cc> - 2017-02-27 21:40 +0100

csiph-web