Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1588464

Re: [RFC][PATCH 07/10] orangefs: Use RCU for destroy_inode

From Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups linux.kernel
Subject Re: [RFC][PATCH 07/10] orangefs: Use RCU for destroy_inode
Date 2017-02-27 02:30 +0100
Message-ID <tfiit-6CW-1@gated-at.bofh.it> (permalink)
References (1 earlier) <tet6h-4bt-9@gated-at.bofh.it> <tev85-5AX-7@gated-at.bofh.it> <tex9T-7mc-9@gated-at.bofh.it> <teRih-4H9-9@gated-at.bofh.it> <tfhw5-632-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sun, Feb 26, 2017 at 4:34 PM, Mike Marshall <hubcap@omnibond.com> wrote:
> Since Orangefs uses ref-walk, not rcu-walk, this patch with call_rcu
> has seemed weird to me.

Even if orangefs never really allows RCU walking, the VFS layer will
look up dentries - and look at their inodes - from RCU. It will then
call into the filesystem

So even if orangefs always returned ECHILD (it doesn't - it has a
timeout) - we'd be following the dentry inode pointer in jus a RCU
read region.

           Linus

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC][PATCH 07/10] orangefs: Use RCU for destroy_inode Peter Zijlstra <peterz@infradead.org> - 2017-02-24 19:50 +0100
  Re: [RFC][PATCH 07/10] orangefs: Use RCU for destroy_inode Al Viro <viro@ZenIV.linux.org.uk> - 2017-02-24 22:00 +0100
    Re: [RFC][PATCH 07/10] orangefs: Use RCU for destroy_inode Mike Marshall <hubcap@omnibond.com> - 2017-02-25 00:10 +0100
      Re: [RFC][PATCH 07/10] orangefs: Use RCU for destroy_inode Mike Marshall <hubcap@omnibond.com> - 2017-02-25 21:40 +0100
        Re: [RFC][PATCH 07/10] orangefs: Use RCU for destroy_inode Mike Marshall <hubcap@omnibond.com> - 2017-02-27 01:40 +0100
          Re: [RFC][PATCH 07/10] orangefs: Use RCU for destroy_inode Linus Torvalds <torvalds@linux-foundation.org> - 2017-02-27 02:30 +0100
          Re: [RFC][PATCH 07/10] orangefs: Use RCU for destroy_inode David Howells <dhowells@redhat.com> - 2017-02-27 10:00 +0100
            Re: [RFC][PATCH 07/10] orangefs: Use RCU for destroy_inode Mike Marshall <hubcap@omnibond.com> - 2017-02-27 15:50 +0100

csiph-web