Re: [PATCH v2] drm/color: Document CTM eqations

From	Daniel Vetter <daniel@ffwll.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] drm/color: Document CTM eqations
Date	2017-02-26 21:00 +0100
Message-ID	<tfd97-2SY-13@gated-at.bofh.it> (permalink)
References	(3 earlier) <t5KJ4-3yR-27@gated-at.bofh.it> <t5KJ4-3yR-25@gated-at.bofh.it> <tb6fT-7Pm-3@gated-at.bofh.it> <tb6pz-7Tn-9@gated-at.bofh.it> <tbReO-4Z1-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Feb 17, 2017 at 01:54:52PM +0000, Brian Starkey wrote:
> What's the verdict? We've got [1] which is about to become another
> (driver) implementation - better to change before that merges than
> after I guess.

We could also just switch the internal representation to something more
reasonable, and add glue code in the atomic core to remap between whatever
the properties are and the internal representation. Same thing we
essentially already do with the display mode.

That would then also extend to CTM2 or whatever.

For sure not really a good reason to stall a driver imo.
-Daniel

> 
> -Brian
> 
> [1] https://lkml.org/lkml/2017/2/13/304
> 
> On Wed, Feb 15, 2017 at 11:56:55AM +0000, Daniel Stone wrote:
> > Hi,
> > 
> > On 15 February 2017 at 11:39, Ville Syrjälä
> > <ville.syrjala@linux.intel.com> wrote:
> > > On Tue, Jan 31, 2017 at 06:46:39PM +0100, Daniel Vetter wrote:
> > > > On Tue, Jan 31, 2017 at 6:22 PM, Ville Syrjälä
> > > > <ville.syrjala@linux.intel.com> wrote:
> > > > > Hmm. Two's complement is what I was thinking it is. Which shows that
> > > > > I never managed to read the code in any detail. Definitely needs to
> > > > > be documented properly.
> > > > 
> > > > That sounds supremely backwards. I guess we can't fix this anymore?
> > > 
> > > I have no idea. Anyone else?
> > 
> > I don't know of any implementation using this; maybe closed Intel
> > Android stuff? Certainly GitHub showed no-one using it, and neither X
> > nor Weston/Mutter are using it yet.
> > 
> > Cheers,
> > Daniel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] drm/color: Document CTM eqations Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-02-15 12:50 +0100
  Re: [PATCH v2] drm/color: Document CTM eqations Daniel Stone <daniel@fooishbar.org> - 2017-02-15 13:00 +0100
    Re: [PATCH v2] drm/color: Document CTM eqations Brian Starkey <brian.starkey@arm.com> - 2017-02-17 15:00 +0100
      Re: [PATCH v2] drm/color: Document CTM eqations Lionel Landwerlin <lionel.g.landwerlin@intel.com> - 2017-02-17 15:50 +0100
        Re: [PATCH v2] drm/color: Document CTM eqations Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-02-17 16:00 +0100
          Re: [PATCH v2] drm/color: Document CTM eqations Lionel Landwerlin <lionel.g.landwerlin@intel.com> - 2017-02-17 16:10 +0100
            Re: [PATCH v2] drm/color: Document CTM eqations Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-02-17 16:20 +0100
          Re: [PATCH v2] drm/color: Document CTM eqations Daniel Stone <daniel@fooishbar.org> - 2017-02-17 16:20 +0100
      Re: [PATCH v2] drm/color: Document CTM eqations Daniel Vetter <daniel@ffwll.ch> - 2017-02-26 21:00 +0100

csiph-web