Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1583501

Re: [PATCH v2] drm/color: Document CTM eqations

Show all headers | View raw

On Fri, Feb 17, 2017 at 02:42:26PM +0000, Lionel Landwerlin wrote:
> On 17/02/17 13:54, Brian Starkey wrote:
> > What's the verdict? We've got [1] which is about to become another
> > (driver) implementation - better to change before that merges than
> > after I guess.
> >
> > -Brian
> >
> > [1] https://lkml.org/lkml/2017/2/13/304
> >
> > On Wed, Feb 15, 2017 at 11:56:55AM +0000, Daniel Stone wrote:
> >> Hi,
> >>
> >> On 15 February 2017 at 11:39, Ville Syrjälä
> >> <ville.syrjala@linux.intel.com> wrote:
> >>> On Tue, Jan 31, 2017 at 06:46:39PM +0100, Daniel Vetter wrote:
> >>>> On Tue, Jan 31, 2017 at 6:22 PM, Ville Syrjälä
> >>>> <ville.syrjala@linux.intel.com> wrote:
> >>>> > Hmm. Two's complement is what I was thinking it is. Which shows that
> >>>> > I never managed to read the code in any detail. Definitely needs to
> >>>> > be documented properly.
> >>>>
> >>>> That sounds supremely backwards. I guess we can't fix this anymore?
> >>>
> >>> I have no idea. Anyone else?
> >>
> >> I don't know of any implementation using this; maybe closed Intel
> >> Android stuff? Certainly GitHub showed no-one using it, and neither X
> >> nor Weston/Mutter are using it yet.
> >>
> >> Cheers,
> >> Daniel
> >
> If we're talking fixed point reprsentation, ChromeOS is using this :
> 
> https://cs.chromium.org/chromium/src/ui/ozone/platform/drm/gpu/drm_device.cc?q=DrmDevice&l=209

So it's already using the sign+magnitude stuff. Which presumably
means we can't change it to two's complement anymore :( Maybe we add a
CTM2 property ;)

Using sign+magnitude definitely looks rather inefficient since there's
a branch inside the loop. With two's complement you wouldn't need that
thing slowing you down.

-- 
Ville Syrjälä
Intel OTC

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] drm/color: Document CTM eqations Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-02-15 12:50 +0100
  Re: [PATCH v2] drm/color: Document CTM eqations Daniel Stone <daniel@fooishbar.org> - 2017-02-15 13:00 +0100
    Re: [PATCH v2] drm/color: Document CTM eqations Brian Starkey <brian.starkey@arm.com> - 2017-02-17 15:00 +0100
      Re: [PATCH v2] drm/color: Document CTM eqations Lionel Landwerlin <lionel.g.landwerlin@intel.com> - 2017-02-17 15:50 +0100
        Re: [PATCH v2] drm/color: Document CTM eqations Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-02-17 16:00 +0100
          Re: [PATCH v2] drm/color: Document CTM eqations Lionel Landwerlin <lionel.g.landwerlin@intel.com> - 2017-02-17 16:10 +0100
            Re: [PATCH v2] drm/color: Document CTM eqations Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-02-17 16:20 +0100
          Re: [PATCH v2] drm/color: Document CTM eqations Daniel Stone <daniel@fooishbar.org> - 2017-02-17 16:20 +0100
      Re: [PATCH v2] drm/color: Document CTM eqations Daniel Vetter <daniel@ffwll.ch> - 2017-02-26 21:00 +0100

csiph-web