Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1589725

Re: [PATCH v2] staging: iio: accel: Move header file content to source file

From Lars-Peter Clausen <lars@metafoo.de>
Newsgroups linux.kernel
Subject Re: [PATCH v2] staging: iio: accel: Move header file content to source file
Date 2017-02-28 20:40 +0100
Message-ID <tfVMS-oA-11@gated-at.bofh.it> (permalink)
References <tfVaa-8nb-19@gated-at.bofh.it> <tfVDb-lh-5@gated-at.bofh.it> <tfVDb-lh-3@gated-at.bofh.it> <tfVMR-oA-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 02/28/2017 08:32 PM, SIMRAN SINGHAL wrote:
> On Wed, Mar 1, 2017 at 12:53 AM, Jonathan Cameron <jic23@kernel.org> wrote:
>> On 28/02/17 19:17, Jonathan Cameron wrote:
>>> On 28/02/17 18:51, simran singhal wrote:
>>>> The contents of the header file are used only by this single
>>>> source file. Move content into .c and remove .h.
>>>>
>>>> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
>>> Applied to the togreg branch of iio.git and pushed out as testing
>>> for the autobuilders to play with it.
>>>
>>> Thanks,
>>>
>>> Jonathan
>>
>> One quick note:
>>
>> The title should include the name of the driver being modified
>> as this is probably the bit interested people are most likely
>> to pick up on in a long list of patches.
>>
>> I fixed this up.  Thanks,
>>
>> Jonathan
> 
> I have included the name of driver being modified.
> Due to want me to include the name of file i.e adis16201_core.c

Not the full filename, but the partnumber. E.g.

	'staging: iio: adis16201: ...'

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] staging: iio: accel: Move header file content to source  file simran singhal <singhalsimran0@gmail.com> - 2017-02-28 20:00 +0100
  Re: [PATCH v2] staging: iio: accel: Move header file content to  source file Jonathan Cameron <jic23@kernel.org> - 2017-02-28 20:30 +0100
    Re: [PATCH v2] staging: iio: accel: Move header file content to  source file SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-02-28 20:40 +0100
      Re: [PATCH v2] staging: iio: accel: Move header file content to  source file Lars-Peter Clausen <lars@metafoo.de> - 2017-02-28 20:40 +0100
        Re: [PATCH v2] staging: iio: accel: Move header file content to  source file SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-02-28 22:30 +0100
  Re: [PATCH v2] staging: iio: accel: Move header file content to  source file Jonathan Cameron <jic23@kernel.org> - 2017-02-28 20:40 +0100

csiph-web