Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1589327

Re: [PATCH v3 6/6] ARM: davinci: add enable GPIOs for vpif capture to pdata-quirks

Show all headers | View raw

2017-02-28 9:49 GMT+01:00 Sekhar Nori <nsekhar@ti.com>:
> On Wednesday 22 February 2017 07:43 PM, Bartosz Golaszewski wrote:
>> On the da850-evm board we need to select the UI expander video capture
>> function to make vpif capture work. Add the relevant GPIOs to the
>> pdata-quirks.
>>
>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Hmm, why do we need this despite enable-gpios in DT ?
>

I didn't look at the exact code path, but if we're using pdata-quirks,
the of_node in struct device passed to vpif_probe is NULL (one of the
reasons why we're not mixing DT and pdata for vpif subdevices
configuration etc.). So it seems that as long as we don't switch over
to DT entirely we need to have the GPIOs here as well.

Thanks,
Bartosz

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/6] ARM: davinci: vpif capture & display support Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-22 15:20 +0100
  [PATCH v3 1/6] ARM: davinci: da8xx: allow having multiple pdata-quirks Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-22 15:20 +0100
    Re: [PATCH v3 1/6] ARM: davinci: da8xx: allow having multiple pdata-quirks Kevin Hilman <khilman@baylibre.com> - 2017-02-28 19:10 +0100
  [PATCH v3 4/6] ARM: da850-evm: add a fixed regulator for the UI board IO expander Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-22 15:20 +0100
  [PATCH v3 5/6] ARM: davinci: add pdata-quirks for da850-evm vpif display Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-22 15:20 +0100
  [PATCH v3 2/6] ARM: davinci: board-da850-evm: add I2C ID for VPIF Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-22 15:20 +0100
  [PATCH v3 3/6] ARM: davinci: da8xx: add pdata-quirks for VPIF capture Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-22 15:20 +0100
    Re: [PATCH v3 3/6] ARM: davinci: da8xx: add pdata-quirks for VPIF  capture Sekhar Nori <nsekhar@ti.com> - 2017-02-28 10:00 +0100
  [PATCH v3 6/6] ARM: davinci: add enable GPIOs for vpif capture to pdata-quirks Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-22 15:20 +0100
    Re: [PATCH v3 6/6] ARM: davinci: add enable GPIOs for vpif capture to  pdata-quirks Sekhar Nori <nsekhar@ti.com> - 2017-02-28 10:10 +0100
      Re: [PATCH v3 6/6] ARM: davinci: add enable GPIOs for vpif capture to pdata-quirks Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-28 11:00 +0100

csiph-web