Re: [PATCH v2 2/5] KVM: add KVM request variants without barrier

From	Peter Xu <peterx@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/5] KVM: add KVM request variants without barrier
Date	2017-02-28 08:50 +0100
Message-ID	<tfKHM-1jq-9@gated-at.bofh.it> (permalink)
References	<teuc1-4Ze-5@gated-at.bofh.it> <teuc2-4Ze-9@gated-at.bofh.it> <tfKy5-1gf-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Feb 28, 2017 at 03:34:24PM +0800, Peter Xu wrote:

[...]

> > diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c
> > index ee4af898bcf6..552ae2b5e911 100644
> > --- a/arch/mips/kvm/emulate.c
> > +++ b/arch/mips/kvm/emulate.c
> > @@ -865,7 +865,7 @@ enum emulation_result kvm_mips_emul_wait(struct kvm_vcpu *vcpu)
> >  		 * check if any I/O interrupts are pending.
> >  		 */
> >  		if (kvm_request_test_and_clear(KVM_REQ_UNHALT, vcpu)) {
> > -			clear_bit(KVM_REQ_UNHALT, &vcpu->requests);
> > +			__kvm_request_clear(KVM_REQ_UNHALT, vcpu);
> 
> Shall we just remove above line since we cleared it already?

Please ignore this since I see patch 4. :-)

It'll be nice if patch 4 will be before this one, but it's trivial.

Thanks,

-- peterx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 2/5] KVM: add KVM request variants without barrier Radim Krčmář <rkrcmar@redhat.com> - 2017-02-24 21:00 +0100
  Re: [PATCH v2 2/5] KVM: add KVM request variants without barrier David Hildenbrand <david@redhat.com> - 2017-02-27 11:10 +0100
    Re: [PATCH v2 2/5] KVM: add KVM request variants without barrier David Hildenbrand <david@redhat.com> - 2017-02-27 11:30 +0100
  Re: [PATCH v2 2/5] KVM: add KVM request variants without barrier Peter Xu <peterx@redhat.com> - 2017-02-28 08:40 +0100
    Re: [PATCH v2 2/5] KVM: add KVM request variants without barrier Peter Xu <peterx@redhat.com> - 2017-02-28 08:50 +0100

csiph-web