Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1588947

Re: [PATCH v2 3/3] percpu: improve allocation success rate for non-GFP_KERNEL callers

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Tahsin Erdogan <tahsin@google.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 3/3] percpu: improve allocation success rate for non-GFP_KERNEL callers
Date Mon, 27 Feb 2017 22:20:01 +0100
Message-ID <tfAS5-2SI-3@gated-at.bofh.it> (permalink)
References <teVce-7pj-3@gated-at.bofh.it> <teYWt-1zx-1@gated-at.bofh.it> <tfqzo-491-15@gated-at.bofh.it> <tftdU-5Yo-25@gated-at.bofh.it> <tfA5I-2i1-17@gated-at.bofh.it> <tfA5I-2i1-15@gated-at.bofh.it> <tfAfo-2lV-13@gated-at.bofh.it> <tfAp4-2r5-21@gated-at.bofh.it> <tfAS5-2SI-5@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=kXmbCSh6nmM2yV6EmNFFYfGtVaiAIK+zLFMkznWECbg=; b=RXiY8ZfakS/eOAhnyFiucaeRzxzLip/2i1JylbD7qaUfWOCeULz/DC//l1A7sLllWl lcQ2z2AD0rTpYCu9NKKg6BRCr3kPrpF+9zUt/I+fv3OtZ0HexImHz4AzKZhXO70AYG/6 c0Zv92XVigPfh4vhnB6pjHjpiA0gV9aYZ/W4JENUnA1ivckAGPM92H7shb516TtYA/hT KauSFZIn5khmbxa/ePvOxmo3Q7otqTyuSSiniEs3Lcd5D6/5N8WAq5GXnB9ImY/BnAek oYZfYhM5r2ON9ZNsX8nwisxzGDF6ZIwq4iZWBpNA7oT795k3OM4eCoZ/ymjZb/OjvKrT Qoew==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kXmbCSh6nmM2yV6EmNFFYfGtVaiAIK+zLFMkznWECbg=; b=m9TmekzqBvj+MSz3JlUJH/JtTZrFw7msJzJCe/RSGqJk7kKun9BdGKehuFKdz9UvMs 1vZrpmT3mLW3eh4+MAEjdGG6IgW+WUH1t+3qr4vGu8fFpvoO2Y/bt7aU4QPVWuEmUJ50 Zuxwl4+YURscGLIrPyeLiP72xNyr5Mv0qftVtcg7nTBl4ufKM/3WF6nioBQews+roXsk 8v9ZgIkNUZUWp8jXA1Sd9JOoHPQ1vfV2bX4QO7apNOQAswuayBjTxE78KG524ySFepCU VTBHeoH3oj/5Ie5ALNjPwNyevshZYJhAhanf8PAThXtcMI13Da2WOR73+9E/451WpUei Txhw==
X-Gm-Message-State AMke39naGdZVyXJHfBrBPsvMOyPURwJkrVxZuTYlWPUykeB+FzsRVe2NTs+o9H5GlOaMqIbmPPDDcSIT0iM5rKZO
X-Received by 10.36.14.213 with SMTP id 204mr15747095ite.80.1488229931872; Mon, 27 Feb 2017 13:12:11 -0800 (PST)
MIME-Version 1.0
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 14
Organization linux.* mail to news gateway
X-Original-Cc Michal Hocko <mhocko@kernel.org>, Christoph Lameter <cl@linux.com>, Andrew Morton <akpm@linux-foundation.org>, Chris Wilson <chris@chris-wilson.co.uk>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Roman Pen <r.peniaev@gmail.com>, Joonas Lahtinen <joonas.lahtinen@linux.intel.com>, zijun_hu <zijun_hu@htc.com>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, David Rientjes <rientjes@google.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org
X-Original-Date Mon, 27 Feb 2017 13:12:11 -0800
X-Original-Message-ID <CAAeU0aPGvoYr=dtbRWT3=S5x9HmkUEiGmGWQy0JdFVu3F40N9g@mail.gmail.com>
X-Original-References <201702260805.zhem8KFI%fengguang.wu@intel.com> <20170226043829.14270-1-tahsin@google.com> <20170227095258.GG14029@dhcp22.suse.cz> <CAAeU0aMaGa63Nj=JvZKKy82FftAT9dF56=gZsufDvrkqDSGUrw@mail.gmail.com> <20170227195126.GC8707@htj.duckdns.org> <CAAeU0aORY=N0e0gMKu-CBAEF=HLuHUNV6KWy27th1rwuPMcTMg@mail.gmail.com> <20170227202906.GF8707@htj.duckdns.org> <CAAeU0aMnz-nsXGy44mwBfzwfFJtVWNRQiAE0UAonBQA3iDJBqg@mail.gmail.com> <20170227204527.GG8707@htj.duckdns.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1588947

Show key headers only | View raw

>> Doing preallocations would probably work but not sure if that can be
>> done without
>> complicating code too much. Could you describe what you have in mind?
>
> So, blkg_create() already takes @new_blkg argument which is the
> preallocated blkg and used during q init.  Wouldn't it work to make
> blkg_lookup_create() take @new_blkg too and pass it down to
> blkg_create() (and also free it if it doesn't get used)?  Then,
> blkg_conf_prep() can always (or after a failure with -ENOMEM) allocate
> a new blkg before calling into blkg_lookup_create().  I don't think
> it'll complicate the code path that much.

That makes sense. I will work a patch that does that (unless you are
interested in implementing it yourself).

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] percpu: improve allocation success rate for non-GFP_KERNEL callers Tahsin Erdogan <tahsin@google.com> - 2017-02-25 22:10 +0100
  Re: [PATCH 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers kbuild test robot <lkp@intel.com> - 2017-02-26 01:00 +0100
  Re: [PATCH 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers kbuild test robot <lkp@intel.com> - 2017-02-26 01:50 +0100
    [PATCH v2 3/3] percpu: improve allocation success rate for non-GFP_KERNEL callers Tahsin Erdogan <tahsin@google.com> - 2017-02-26 05:50 +0100
      Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Michal Hocko <mhocko@kernel.org> - 2017-02-27 11:20 +0100
        Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Tahsin Erdogan <tahsin@google.com> - 2017-02-27 14:10 +0100
          Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Michal Hocko <mhocko@kernel.org> - 2017-02-27 16:30 +0100
            Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Michal Hocko <mhocko@kernel.org> - 2017-02-27 18:10 +0100
              Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Michal Hocko <mhocko@kernel.org> - 2017-02-27 18:40 +0100
                Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Tahsin Erdogan <tahsin@google.com> - 2017-02-27 20:40 +0100
                Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Michal Hocko <mhocko@kernel.org> - 2017-02-27 20:50 +0100
            Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Tahsin Erdogan <tahsin@google.com> - 2017-02-27 18:10 +0100
          Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Tahsin Erdogan <tahsin@google.com> - 2017-02-27 21:30 +0100
            Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Tejun Heo <tj@kernel.org> - 2017-02-27 21:40 +0100
              Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Tahsin Erdogan <tahsin@google.com> - 2017-02-27 21:50 +0100
                Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Tahsin Erdogan <tahsin@google.com> - 2017-02-27 22:20 +0100
                Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Tejun Heo <tj@kernel.org> - 2017-02-27 22:40 +0100
                Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Tejun Heo <tj@kernel.org> - 2017-02-27 23:40 +0100
          Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Tejun Heo <tj@kernel.org> - 2017-02-27 23:40 +0100

csiph-web